fix: don't inject latency unless requested

Author: 0x416e746f6e

cmd/serve.go

@@ -87,7 +87,6 @@ func CommandServe(cfg *config.Config) *cli.Command {
 				EnvVars:     []string{envPrefix + strings.ToUpper(categoryChaos+"_"+category) + "_MIN_INJECTED_LATENCY"},
 				Name:        categoryChaos + "-" + category + "-min-injected-latency",
 				Usage:       "min `latency` to enforce on every response processed by " + category + " proxy",
-				Value:       100 * time.Millisecond,
 			},
 
 			&cli.DurationFlag{ // --chaos-xxx-max-injected-latency
@@ -382,7 +381,6 @@ func CommandServe(cfg *config.Config) *cli.Command {
 			EnvVars:     []string{envPrefix + strings.ToUpper(categoryChaos) + "_FLASHBLOCKS_MIN_INJECTED_LATENCY"},
 			Name:        categoryChaos + "-flashblocks-min-injected-latency",
 			Usage:       "min `latency` to enforce on every response processed by flashblocks proxy",
-			Value:       100 * time.Millisecond,
 		},
 
 		&cli.DurationFlag{ // --chaos-flashblocks-max-injected-latency

proxy/http.go

@@ -583,12 +583,14 @@ func (p *HTTP) execProxyJob(job *proxyJob) {
 	}
 
 	if p.cfg.proxy.Chaos.Enabled { // chaos-inject latency
-		loggedFields = append(loggedFields,
-			zap.Bool("chaos_injected_latency", true),
-		)
-		latency := time.Duration(rand.Int64N(int64(p.cfg.proxy.Chaos.MaxInjectedLatency) + 1))
-		latency = max(latency, p.cfg.proxy.Chaos.MinInjectedLatency)
-		time.Sleep(latency - time.Since(job.tsReqReceived))
+		if p.cfg.proxy.Chaos.MinInjectedLatency > 0 || p.cfg.proxy.Chaos.MaxInjectedLatency > 0 {
+			loggedFields = append(loggedFields,
+				zap.Bool("chaos_injected_latency", true),
+			)
+			latency := time.Duration(rand.Int64N(int64(p.cfg.proxy.Chaos.MaxInjectedLatency) + 1))
+			latency = max(latency, p.cfg.proxy.Chaos.MinInjectedLatency)
+			time.Sleep(latency - time.Since(job.tsReqReceived))
+		}
 	}
 
 	{ // add log fields

proxy/websocket_pump.go

@@ -193,12 +193,14 @@ func (p *websocketPump) pumpMessages(
 					}
 
 					{ // chaos-inject latency
-						loggedFields = append(loggedFields,
-							zap.Bool("chaos_injected_latency", true),
-						)
-						latency := time.Duration(rand.Int64N(int64(p.cfg.proxy.Chaos.MaxInjectedLatency) + 1))
-						latency = max(latency, p.cfg.proxy.Chaos.MinInjectedLatency)
-						time.Sleep(latency - time.Since(m.ts))
+						if p.cfg.proxy.Chaos.MinInjectedLatency > 0 || p.cfg.proxy.Chaos.MaxInjectedLatency > 0 {
+							loggedFields = append(loggedFields,
+								zap.Bool("chaos_injected_latency", true),
+							)
+							latency := time.Duration(rand.Int64N(int64(p.cfg.proxy.Chaos.MaxInjectedLatency) + 1))
+							latency = max(latency, p.cfg.proxy.Chaos.MinInjectedLatency)
+							time.Sleep(latency - time.Since(m.ts))
+						}
 					}
 				}