Skip to content

Commit fb31029

Browse files
committed
invert if and reduce LoC
1 parent 88dd0b4 commit fb31029

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

ports/handler.go

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,14 @@ type badRequestParams struct {
1818

1919
func (h *handler) BadRequest(w http.ResponseWriter, r *http.Request, msg string, errs ...error) {
2020
w.WriteHeader(http.StatusBadRequest)
21-
if errs != nil {
22-
err := errs[0]
23-
h.log.Warn(msg, "err", err)
24-
_ = json.NewEncoder(w).Encode(&badRequestParams{
25-
Message: msg,
26-
Error: err.Error(),
27-
})
21+
if errs == nil {
22+
h.log.Warn(msg)
23+
_ = json.NewEncoder(w).Encode(&badRequestParams{Message: msg})
2824
return
2925
}
30-
h.log.Warn(msg)
26+
h.log.Warn(msg, "err", errs[0])
3127
_ = json.NewEncoder(w).Encode(&badRequestParams{
3228
Message: msg,
29+
Error: errs[0].Error(),
3330
})
3431
}

0 commit comments

Comments
 (0)