Skip to content

Revert "Add mkosi flashbots-images VM to playground"#365

Merged
canercidam merged 1 commit intomainfrom
revert-302-fryd/mkosi-playground
Feb 11, 2026
Merged

Revert "Add mkosi flashbots-images VM to playground"#365
canercidam merged 1 commit intomainfrom
revert-302-fryd/mkosi-playground

Conversation

@canercidam
Copy link
Member

Reverts #302

@canercidam canercidam merged commit 4a78a84 into main Feb 11, 2026
14 checks passed
@canercidam canercidam deleted the revert-302-fryd/mkosi-playground branch February 11, 2026 23:21
@claude
Copy link
Contributor

claude bot commented Feb 11, 2026

Claude finished @canercidam's task in 2m 36s —— View job


Review of PR #365: Revert "Add mkosi flashbots-images VM to playground"

  • Gather context and understand the revert scope
  • Review modified Go files for correctness
  • Review deleted files for completeness
  • Check for any unintended changes
  • Post review summary

This is a clean revert of PR #302. I reviewed all 24 changed files and the revert looks correct. The changes properly restore the pre-#302 state:

Go code changes - All modifications are clean reversals:

  • components.go: Restores --target-peers 0 (from 1), re-enables healthmon for Lighthouse beacon and MevBoostRelay, removes Fileserver component, simplifies registerBuilderHook signature and postHook.Action signature back to func(s *Service) error, removes builderHubConfig struct and embedded default config
  • manifest.go: Restores postHook.Action to func(s *Service) error (removing *Manifest param)
  • recipe_buildernet.go: Removes BuilderHostIPAddress const, removes beacon/reth API lookups from registerBuilder, simplifies function signature
  • recipe_l1.go: Removes Fileserver component from L1 recipe
  • artifacts.go: Removes ElectraForkEpoch = 0 and embedded builderhub-config.yaml
  • components_test.go: Updates registerBuilder call to match reverted 2-arg signature

Deleted files - All 16 files under scripts/buildernet-vm/ and playground/utils/builderhub-config.yaml are correctly removed.

Dependencies - go-ethereum reverts from v1.16.8 to v1.16.3, golang/snappy from v1.0.0 to v0.0.5-pre. golang.org/x/time changes from v0.9.0 to v0.11.0 (this is an upgrade, not a downgrade — likely due to transitive dependency resolution).

No issues found. The revert is clean and complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant