Skip to content

feat: enable envs for host process#398

Merged
canercidam merged 1 commit intomainfrom
feat/host-process-env
Mar 10, 2026
Merged

feat: enable envs for host process#398
canercidam merged 1 commit intomainfrom
feat/host-process-env

Conversation

@julio4
Copy link
Member

@julio4 julio4 commented Mar 9, 2026

No description provided.

@julio4 julio4 requested a review from canercidam as a code owner March 9, 2026 04:30
@claude
Copy link
Contributor

claude bot commented Mar 9, 2026

Claude finished @julio4's task in 1m 8s —— View job


PR Review: enable envs for host process

  • Analyze the diff
  • Review code quality and correctness
  • Post review feedback

Summary

The change correctly wires up the previously-ignored envs return value from applyTemplate and passes them to host processes. The TODO removal is good.

One issue found: env values don't go through the FilesMapped/VolumesMapped path substitution that args do (lines 936-950). If an env var references a docker path like /artifacts/jwt.hex, it won't be resolved to the host path. See inline comment for details and a suggested fix.

@canercidam canercidam merged commit 1c3c297 into main Mar 10, 2026
13 checks passed
@canercidam canercidam deleted the feat/host-process-env branch March 10, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants