Fix false positive in boolean flag (#500)

fix(redis): move WasBidSaved to after exec

We have several conditions where we don't execute the pipelined
commands. Only set the WasBidSaved flag after we execute the pipeline
successfully. Do note, if the pipeline fails we may or may not have
actually saved the bid.

Author: alextes

datastore/redis.go

@@ -513,7 +513,6 @@ func (r *RedisCache) SaveBidAndUpdateTopBid(ctx context.Context, pipeliner redis
 	if err != nil {
 		return state, err
 	}
-	state.WasBidSaved = true
 	builderBids.bidValues[payload.BuilderPubkey().String()] = payload.Value()
 
 	// Record time needed to save bid
@@ -543,6 +542,8 @@ func (r *RedisCache) SaveBidAndUpdateTopBid(ctx context.Context, pipeliner redis
 		return state, err
 	}
 	state.IsNewTopBid = payload.Value().Cmp(state.TopBidValue) == 0
+	// An Exec happens in _updateTopBid.
+	state.WasBidSaved = true
 
 	// Record time needed to update top bid
 	nextTime = time.Now().UTC()