metric block_sim_errors always output zero (#245)

dvush · web-flow · commit 0ced7b052e5a · 2024-11-13T14:05:22.000+01:00
diff --git a/crates/rbuilder/src/telemetry/metrics.rs b/crates/rbuilder/src/telemetry/metrics.rs
@@ -109,10 +109,7 @@ register_metrics! {
         &["relay", "kind"]
     )
     .unwrap();
-    pub static BLOCK_SIM_ERRORS: IntCounterVec = IntCounterVec::new(
-        Opts::new("block_sim_errors", "counter of block simulation errors"),
-        &[]
-    )
+    pub static BLOCK_SIM_ERRORS: IntCounter = IntCounter::new("block_sim_errors", "counter of block simulation errors")
     .unwrap();
     pub static SIMULATED_OK_ORDERS: IntCounter =
         IntCounter::new("simulated_ok_orders", "Simulated succeeded orders").unwrap();
@@ -246,7 +243,7 @@ pub fn inc_too_many_req_relay_errors(relay: &MevBoostRelayID) {
 }
 
 pub fn inc_failed_block_simulations() {
-    BLOCK_SIM_ERRORS.with_label_values(&[]).inc()
+    BLOCK_SIM_ERRORS.inc()
 }
 
 pub fn set_current_block(block: u64) {

Original file line number	Diff line number	Diff line change
`@@ -109,10 +109,7 @@ register_metrics! {`
`109`	`109`	`&["relay", "kind"]`
`110`	`110`	`)`
`111`	`111`	`.unwrap();`
`112`		`- pub static BLOCK_SIM_ERRORS: IntCounterVec = IntCounterVec::new(`
`113`		`- Opts::new("block_sim_errors", "counter of block simulation errors"),`
`114`		`- &[]`
`115`		`- )`
	`112`	`+ pub static BLOCK_SIM_ERRORS: IntCounter = IntCounter::new("block_sim_errors", "counter of block simulation errors")`
`116`	`113`	`.unwrap();`
`117`	`114`	`pub static SIMULATED_OK_ORDERS: IntCounter =`
`118`	`115`	`IntCounter::new("simulated_ok_orders", "Simulated succeeded orders").unwrap();`
`@@ -246,7 +243,7 @@ pub fn inc_too_many_req_relay_errors(relay: &MevBoostRelayID) {`
`246`	`243`	`}`
`247`	`244`
`248`	`245`	`pub fn inc_failed_block_simulations() {`
`249`		`- BLOCK_SIM_ERRORS.with_label_values(&[]).inc()`
	`246`	`+ BLOCK_SIM_ERRORS.inc()`
`250`	`247`	`}`
`251`	`248`
`252`	`249`	`pub fn set_current_block(block: u64) {`