chore: reduce realloc

Author: nkysg

crates/rbuilder/src/backtest/backtest_build_block.rs

@@ -319,7 +319,7 @@ fn print_onchain_block_data(
     orders: &[Order],
     block_data: &BlockData,
 ) {
-    let mut executed_orders = Vec::new();
+    let mut executed_orders = Vec::with_capacity(tx_sim_results.len());
 
     let txs_to_idx: HashMap<_, _> = tx_sim_results
         .iter()

crates/rbuilder/src/backtest/fetch/flashbots_db.rs

@@ -1,13 +1,11 @@
-use crate::backtest::BuiltBlockData;
-use crate::primitives::OrderId;
 use crate::{
     backtest::{
         fetch::data_source::{BlockRef, DataSource, DatasourceData},
-        OrdersWithTimestamp,
+        BuiltBlockData, OrdersWithTimestamp,
     },
     primitives::{
         serialize::{RawBundle, RawOrder, RawShareBundle, TxEncoding},
-        Order, SimValue,
+        Order, OrderId, SimValue,
     },
 };
 use alloy_primitives::I256;
@@ -19,8 +17,7 @@ use bigdecimal::{
 use eyre::WrapErr;
 use reth_primitives::{Bytes, B256, U256, U64};
 use sqlx::postgres::PgPool;
-use std::collections::HashSet;
-use std::{ops::Mul, str::FromStr};
+use std::{collections::HashSet, ops::Mul, str::FromStr};
 use time::{OffsetDateTime, PrimitiveDateTime};
 use tracing::trace;
 use uuid::Uuid;
@@ -333,7 +330,8 @@ impl RelayDB {
         .fetch_all(&self.pool)
         .await?;
 
-        let mut included_orders = Vec::new();
+        let mut included_orders =
+            Vec::with_capacity(included_bundles.len() + included_sbundles.len());
         for (bundle_uuid,) in included_bundles {
             let order_id = OrderId::Bundle(bundle_uuid);
             included_orders.push(order_id);

crates/rbuilder/src/backtest/fetch/mempool.rs

@@ -1,9 +1,8 @@
 //! Implementation of [`DataSource`] to bring mempool txs from flashbots' mempool dumpster.
 //! It downloads all the needed parquet files and keeps them cached for future use.
-use crate::backtest::fetch::data_source::DatasourceData;
 use crate::{
     backtest::{
-        fetch::data_source::{BlockRef, DataSource},
+        fetch::data_source::{BlockRef, DataSource, DatasourceData},
         OrdersWithTimestamp,
     },
     primitives::{

crates/rbuilder/src/backtest/mod.rs

@@ -12,14 +12,13 @@ pub use backtest_build_block::run_backtest_build_block;
 pub use backtest_build_range::run_backtest_build_range;
 use std::collections::HashSet;
 
-use crate::primitives::{OrderId, OrderReplacementKey};
-use crate::utils::offset_datetime_to_timestamp_ms;
 use crate::{
     mev_boost::BuilderBlockReceived,
     primitives::{
         serialize::{RawOrder, RawOrderConvertError, TxEncoding},
-        AccountNonce, Order, SimValue,
+        AccountNonce, Order, OrderId, OrderReplacementKey, SimValue,
     },
+    utils::offset_datetime_to_timestamp_ms,
 };
 use alloy_primitives::{Address, TxHash, I256};
 use alloy_rpc_types::{BlockTransactions, Transaction};

crates/rbuilder/src/backtest/redistribute/cli/csv_output.rs

@@ -1,8 +1,5 @@
 use alloy_primitives::{Address, B256, U256};
-use std::fs::File;
-use std::io;
-use std::io::Write;
-use std::path::Path;
+use std::{fs::File, io, io::Write, path::Path};
 
 #[derive(Debug)]
 pub struct CSVOutputRow {

crates/rbuilder/src/backtest/redistribute/mod.rs

@@ -293,7 +293,7 @@ where
     })
     .collect::<Vec<_>>();
 
-    let mut simplified_orders = Vec::new();
+    let mut simplified_orders = Vec::with_capacity(included_orders_available.len());
 
     for available_order in included_orders_available {
         simplified_orders.push(SimplifiedOrder::new_from_order(&available_order.order));
@@ -880,7 +880,11 @@ fn calc_inclusion_change(
     exclusion_result: &ExclusionResult,
     included_before: &[(OrderId, U256)],
 ) -> Vec<OrderInclusionChange> {
-    let mut result = Vec::new();
+    let mut result = Vec::with_capacity(
+        exclusion_result.new_orders_included.len()
+            + exclusion_result.new_orders_failed.len()
+            + exclusion_result.orders_profit_changed.len(),
+    );
     for (id, profit_after) in &exclusion_result.new_orders_included {
         result.push((
             *id,

crates/rbuilder/src/backtest/redistribute/redistribution_algo.rs

@@ -141,10 +141,11 @@ pub fn calculate_redistribution(data: RedistributionCalculator) -> Redistributio
     }
 
     let mut total_value_redistributed = U256::ZERO;
-    let mut redistribution_entity_result = Vec::new();
+    let mut redistribution_entity_result = Vec::with_capacity(n);
     for i in 0..n {
-        let mut order_id_vector = Vec::new();
-        let mut order_contrib_vector = Vec::new();
+        let mut order_id_vector = Vec::with_capacity(data.identity_data[i].included_orders.len());
+        let mut order_contrib_vector =
+            Vec::with_capacity(data.identity_data[i].included_orders.len());
         for landed_order in &data.identity_data[i].included_orders {
             order_id_vector.push(landed_order.id);
             order_contrib_vector.push(landed_order.realized_value);
@@ -230,7 +231,7 @@ fn split_value(value: U256, split_vector: &[U256]) -> Vec<U256> {
     if total_split.is_zero() {
         return split_vector.iter().map(|_| U256::ZERO).collect();
     }
-    let mut result = Vec::new();
+    let mut result = Vec::with_capacity(split_vector.len());
     for split in split_vector {
         result.push((value * split) / total_split);
     }

crates/rbuilder/src/backtest/restore_landed_orders/find_landed_orders.rs

@@ -1,5 +1,7 @@
-use crate::primitives::{Order, OrderId, ShareBundleBody, ShareBundleInner, TxRevertBehavior};
-use crate::utils::get_percent;
+use crate::{
+    primitives::{Order, OrderId, ShareBundleBody, ShareBundleInner, TxRevertBehavior},
+    utils::get_percent,
+};
 use ahash::HashMap;
 use alloy_primitives::{B256, I256, U256};
 
@@ -408,8 +410,10 @@ fn find_landed_order_data(
 #[cfg(test)]
 mod tests {
     use super::*;
-    use crate::primitives::{Bundle, MempoolTx, Refund, ShareBundle, ShareBundleTx};
-    use crate::utils::test_utils::*;
+    use crate::{
+        primitives::{Bundle, MempoolTx, Refund, ShareBundle, ShareBundleTx},
+        utils::test_utils::*,
+    };
 
     fn assert_result(
         executed_txs: Vec<ExecutedBlockTx>,

crates/rbuilder/src/backtest/store.rs

@@ -1,17 +1,17 @@
 // store orders in the sqlite database
 
-use crate::backtest::BuiltBlockData;
-use crate::primitives::OrderId;
-use crate::utils::timestamp_ms_to_offset_datetime;
 use crate::{
-    backtest::{BlockData, OrdersWithTimestamp, RawOrdersWithTimestamp},
+    backtest::{BlockData, BuiltBlockData, OrdersWithTimestamp, RawOrdersWithTimestamp},
     mev_boost::BuilderBlockReceived,
-    primitives::serialize::{RawOrder, TxEncoding},
+    primitives::{
+        serialize::{RawOrder, TxEncoding},
+        OrderId,
+    },
+    utils::timestamp_ms_to_offset_datetime,
 };
 use ahash::{HashMap, HashSet};
-use alloy_primitives::utils::{ParseUnits, Unit};
 use alloy_primitives::{
-    utils::{format_ether, parse_ether},
+    utils::{format_ether, parse_ether, ParseUnits, Unit},
     Address, B256, I256, U256,
 };
 use lz4_flex::{block::DecompressError, compress_prepend_size, decompress_size_prepended};
@@ -20,10 +20,10 @@ use sqlx::{
     sqlite::{SqliteConnectOptions, SqliteRow},
     ConnectOptions, Connection, Executor, Row, SqliteConnection,
 };
-use std::str::FromStr;
 use std::{
     ffi::OsString,
     path::{Path, PathBuf},
+    str::FromStr,
 };
 
 /// Version of the data/format on the DB.

crates/rbuilder/src/bin/backtest-distribute.rs

@@ -1,5 +1,4 @@
-use rbuilder::backtest::redistribute::run_backtest_redistribute;
-use rbuilder::live_builder::config::Config;
+use rbuilder::{backtest::redistribute::run_backtest_redistribute, live_builder::config::Config};
 
 #[tokio::main]
 async fn main() -> eyre::Result<()> {