Skip to content

Commit 32cfac4

Browse files
authored
Remote const qualifier to avoid compilation error (#1421)
<!-- .github/pull_request_template.md --> ## πŸ“Œ Description Removing the const qualifier so that compiler could generate the copy constructor. ## πŸ” Related Issues Without the change, I'm seeing the following build error. ``` flashinfer/comm/vllm_custom_all_reduce.cuh:60:35: error: cannot initialize a parameter of type 'void *' with an rvalue of type 'const void *__restrict (*)[8]' 60 | struct __attribute((aligned(16))) RankData { | ^~~~~~~~ ... flashinfer/comm/vllm_custom_all_reduce.cuh:407:26: note: in instantiation of member function 'std::vector<vllm::RankData>::vector' requested here 407 | __T0::vector< RankData> rank_data(num_buffers); | ^ ``` ## πŸš€ Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### βœ… Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## πŸ§ͺ Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. -->
1 parent 038587f commit 32cfac4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

β€Žinclude/flashinfer/comm/vllm_custom_all_reduce.cuh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ struct Signal {
5858
};
5959

6060
struct __align__(16) RankData {
61-
const void* __restrict__ ptrs[8];
61+
void* __restrict__ ptrs[8];
6262
};
6363

6464
struct __align__(16) RankSignals {

0 commit comments

Comments
Β (0)