Skip to content

Commit 73702b7

Browse files
authored
install: remove nvidia-cudnn-12 from package dependency (#1409)
<!-- .github/pull_request_template.md --> ## 📌 Description The dependency is not required because: 1. For x86_64 user environments that installs pytorch from pypi, `nvidia-cudnn-12` is already a torch dependency (https://github.com/pytorch/pytorch/blob/3f1636ebef9b45e8a3cb0eb20d327ee6acb74be0/.github/scripts/generate_binary_build_matrix.py#L44-L95), and flashinfer depends on torch, there is no need to specify another `nvidia-cudnn-12` dependency in flashinfer. 2. For user environments where `nvidia-cudnn-12` is not a torch dependency (like in nvidia's pytorch container), cudnn is installed at system wide and cudnn-frontend will rely on cudnn system installation instead of through `nvidia-cudnn-12`. ## 🔍 Related Issues `nvidia-nvshmem-12` package is a similar redundant dependency: #1388 ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [x] Tests have been added or updated as needed. - [x] All tests are passing (`unittest`, etc.). ## Reviewer Notes <!-- Optional: anything you'd like reviewers to focus on, concerns, etc. -->
1 parent e6c0fc8 commit 73702b7

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

setup.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ def generate_build_meta(aot_build_meta: dict) -> None:
6161
"pynvml",
6262
"einops",
6363
"nvidia-nvshmem-cu12",
64-
"nvidia-cudnn-cu12",
6564
"nvidia-cudnn-frontend>=1.13.0",
6665
]
6766
generate_build_meta({})

0 commit comments

Comments
 (0)