Skip to content

Commit 7c45412

Browse files
yzh119yongwww
andauthored
ci: bugfix on sdist pypi workflow (#1449)
<!-- .github/pull_request_template.md --> ## 📌 Description Remove "Verify tag matches package version" step because it reads package version from `setup.py` or `pyproject.yml` but our version number exist in version.txt. "Verify tag matches version.txt" has already checked the version. ## 🔍 Related Issues <!-- Link any related issues here --> ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [ ] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [ ] I have installed the hooks with `pre-commit install`. - [ ] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes cc @yongwww --------- Co-authored-by: Yong Wu <[email protected]>
1 parent 424981d commit 7c45412

File tree

2 files changed

+1
-23
lines changed

2 files changed

+1
-23
lines changed

.github/workflows/release_pypi_sdist.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -57,28 +57,6 @@ jobs:
5757
5858
echo "✓ version.txt matches tag version: $VERSION_TXT"
5959
60-
- name: Verify tag matches package version
61-
run: |
62-
# Extract version from tag (remove 'v' prefix)
63-
TAG_VERSION="${{ inputs.tag }}"
64-
TAG_VERSION="${TAG_VERSION#v}"
65-
66-
# Extract version from setup.py or pyproject.toml
67-
if [ -f "setup.py" ]; then
68-
PACKAGE_VERSION=$(python -c "import re; content = open('setup.py').read(); match = re.search(r'version\s*=\s*[\"']([^\"']+)[\"']', content); print(match.group(1) if match else '')")
69-
elif [ -f "pyproject.toml" ]; then
70-
PACKAGE_VERSION=$(python -c "import tomllib; data = tomllib.load(open('pyproject.toml', 'rb')); print(data.get('project', {}).get('version', '') or data.get('tool', {}).get('poetry', {}).get('version', ''))")
71-
else
72-
echo "Warning: Could not find version file (setup.py or pyproject.toml)"
73-
PACKAGE_VERSION=""
74-
fi
75-
76-
if [ -n "$PACKAGE_VERSION" ] && [ "$TAG_VERSION" != "$PACKAGE_VERSION" ]; then
77-
echo "Error: Tag version ($TAG_VERSION) does not match package version ($PACKAGE_VERSION)"
78-
exit 1
79-
fi
80-
echo "✓ Package version check passed: $TAG_VERSION"
81-
8260
- name: Install build dependencies
8361
run: |
8462
python -m pip install --upgrade pip

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def generate_build_meta(aot_build_meta: dict) -> None:
5858
"torch",
5959
"ninja",
6060
"requests",
61-
"cuda-python",
61+
"cuda-python<=12.9",
6262
"pynvml",
6363
"einops",
6464
"nvidia-cudnn-frontend>=1.13.0",

0 commit comments

Comments
 (0)