Skip to content

Commit b1b4549

Browse files
authored
fix: missing header include in decode kernel jit binding (#1802)
## 📌 Description This commit adds the missing include of the header `decode.cuh` in the JIT binding `csrc/batch_decode.cu`, without this fix, there will be linking error when linking `batch_decode.o`, `batch_decode_kernel.o` and `batch_decode_jit_binding.o`. The reason is that, `csrc/batch_decode.cu` relies on `scheduler.cuh` for decoding attention planning. `scheduler.cuh` declares the decode kernel of `BatchDecodeWithPagedKVCacheKernel`, which is implemented in `decode.cuh`, but does not include `decode.cuh`. Therefore, if `csrc/batch_decode.cu` does not include `decode.cuh`, the decode kernel will be a symbol that is declared but not implemented. ## 🔍 Related Issues N/A ## 🚀 Pull Request Checklist Thank you for contributing to FlashInfer! Before we review your pull request, please make sure the following items are complete. ### ✅ Pre-commit Checks - [x] I have installed `pre-commit` by running `pip install pre-commit` (or used your preferred method). - [x] I have installed the hooks with `pre-commit install`. - [x] I have run the hooks manually with `pre-commit run --all-files` and fixed any reported issues. > If you are unsure about how to set up `pre-commit`, see [the pre-commit documentation](https://pre-commit.com/). ## 🧪 Tests - [ ] Tests have been added or updated as needed. - [ ] All tests are passing (`unittest`, etc.). ## Reviewer Notes N/A
1 parent 0f8ecab commit b1b4549

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

csrc/batch_decode.cu

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16+
#include <flashinfer/attention/decode.cuh>
1617
#include <flashinfer/attention/scheduler.cuh>
1718
#include <flashinfer/pos_enc.cuh>
1819
#include <flashinfer/utils.cuh>

0 commit comments

Comments
 (0)