You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: missing header include in decode kernel jit binding (#1802)
## 📌 Description
This commit adds the missing include of the header `decode.cuh` in the
JIT binding `csrc/batch_decode.cu`, without this fix, there will be
linking error when linking `batch_decode.o`, `batch_decode_kernel.o` and
`batch_decode_jit_binding.o`.
The reason is that, `csrc/batch_decode.cu` relies on `scheduler.cuh` for
decoding attention planning. `scheduler.cuh` declares the decode kernel
of `BatchDecodeWithPagedKVCacheKernel`, which is implemented in
`decode.cuh`, but does not include `decode.cuh`. Therefore, if
`csrc/batch_decode.cu` does not include `decode.cuh`, the decode kernel
will be a symbol that is declared but not implemented.
## 🔍 Related Issues
N/A
## 🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull
request, please make sure the following items are complete.
### ✅ Pre-commit Checks
- [x] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [x] I have installed the hooks with `pre-commit install`.
- [x] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.
> If you are unsure about how to set up `pre-commit`, see [the
pre-commit documentation](https://pre-commit.com/).
## 🧪 Tests
- [ ] Tests have been added or updated as needed.
- [ ] All tests are passing (`unittest`, etc.).
## Reviewer Notes
N/A
0 commit comments