Commit f4d10a7
<!-- .github/pull_request_template.md -->
## 📌 Description
As mentioned in #2507, `trtllm_fp8_per_tensor_scale_moe` function would
fail when passed integer `activation_type`.
This PR fixes the type mismatch.
## 🔍 Related Issues
<!-- Link any related issues here -->
## 🚀 Pull Request Checklist
Thank you for contributing to FlashInfer! Before we review your pull
request, please make sure the following items are complete.
### ✅ Pre-commit Checks
- [x] I have installed `pre-commit` by running `pip install pre-commit`
(or used your preferred method).
- [x] I have installed the hooks with `pre-commit install`.
- [x] I have run the hooks manually with `pre-commit run --all-files`
and fixed any reported issues.
> If you are unsure about how to set up `pre-commit`, see [the
pre-commit documentation](https://pre-commit.com/).
## 🧪 Tests
- [x] Tests have been added or updated as needed.
- [ ] All tests are passing (`unittest`, etc.).
## Reviewer Notes
<!-- Optional: anything you'd like reviewers to focus on, concerns, etc.
-->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Refactor**
* Public APIs updated: activation_type now accepts integer values
(defaults adjusted to numeric activation codes).
* Call sites and public function signatures aligned to use the numeric
activation_type.
* **Tests**
* Test inputs updated to supply numeric activation_type values instead
of enum members.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Signed-off-by: Dimitrios Bariamis <12195802+dbari@users.noreply.github.com>
Co-authored-by: Dimitrios Bariamis <12195802+dbari@users.noreply.github.com>
1 parent 292f9be commit f4d10a7
File tree
2 files changed
+12
-12
lines changed- flashinfer/fused_moe
- tests/moe
2 files changed
+12
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
989 | 989 | | |
990 | 990 | | |
991 | 991 | | |
992 | | - | |
| 992 | + | |
993 | 993 | | |
994 | 994 | | |
995 | 995 | | |
| |||
1422 | 1422 | | |
1423 | 1423 | | |
1424 | 1424 | | |
1425 | | - | |
| 1425 | + | |
1426 | 1426 | | |
1427 | 1427 | | |
1428 | 1428 | | |
| |||
1482 | 1482 | | |
1483 | 1483 | | |
1484 | 1484 | | |
1485 | | - | |
| 1485 | + | |
1486 | 1486 | | |
1487 | 1487 | | |
1488 | 1488 | | |
| |||
1507 | 1507 | | |
1508 | 1508 | | |
1509 | 1509 | | |
1510 | | - | |
| 1510 | + | |
1511 | 1511 | | |
1512 | 1512 | | |
1513 | 1513 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2667 | 2667 | | |
2668 | 2668 | | |
2669 | 2669 | | |
2670 | | - | |
2671 | | - | |
| 2670 | + | |
| 2671 | + | |
2672 | 2672 | | |
2673 | 2673 | | |
2674 | 2674 | | |
| |||
2855 | 2855 | | |
2856 | 2856 | | |
2857 | 2857 | | |
2858 | | - | |
2859 | | - | |
2860 | | - | |
| 2858 | + | |
| 2859 | + | |
| 2860 | + | |
2861 | 2861 | | |
2862 | 2862 | | |
2863 | 2863 | | |
| |||
2931 | 2931 | | |
2932 | 2932 | | |
2933 | 2933 | | |
2934 | | - | |
2935 | | - | |
| 2934 | + | |
| 2935 | + | |
2936 | 2936 | | |
2937 | 2937 | | |
2938 | 2938 | | |
| |||
3005 | 3005 | | |
3006 | 3006 | | |
3007 | 3007 | | |
3008 | | - | |
| 3008 | + | |
3009 | 3009 | | |
3010 | 3010 | | |
3011 | 3011 | | |
| |||
0 commit comments