Skip to content

Commit 93e5441

Browse files
committed
pkg-auto: Move and reword a comment
After the split off and adding jobs, the comment was bit outdated and out of place, but still useful enough to keep it, but reword it and move into a more relevant place. Signed-off-by: Krzesimir Nowak <[email protected]>
1 parent 096a632 commit 93e5441

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

pkg_auto/impl/pkg_auto_lib.sh

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2088,6 +2088,22 @@ function handle_one_package_change() {
20882088
local new_pkg_slot_verminmax_map_mvm_var_name=${bunch_of_maps_ref[BOM_NEW_PKG_SLOT_VERMINMAX_MAP_MVM_IDX]}
20892089
local -n pkg_sources_map_ref=${bunch_of_maps_ref[BOM_PKG_SOURCES_MAP_IDX]}
20902090

2091+
# The function goes over a pair of old and new package names. For
2092+
# each name there will be some checks done (like does this package
2093+
# even exist). Each name in the pair has a set of used slots
2094+
# associated with it (the most common situation is that each have
2095+
# just one slot, but there are some packages that we have multiple
2096+
# slots installed, like app-text/docbook-xml-dtd). Some of the
2097+
# slots will appear in both old and new package name, sometimes
2098+
# there will be slots available only in the old state or only in
2099+
# the new state. Each slot for each package name has an associated
2100+
# min version and max version. So for common slots we usually
2101+
# compare min version for old package with max version for new
2102+
# package. Any inconsistencies with the versions should be
2103+
# reported by now. There are some edge cases with the slots that
2104+
# are not handled by the automation - in such cases there will be
2105+
# a "manual action needed" report.
2106+
20912107
if [[ ${old_name} = "${new_name}" ]]; then
20922108
info "handling update of ${new_name}"
20932109
else
@@ -2616,23 +2632,6 @@ function handle_package_changes() {
26162632
done
26172633
done
26182634

2619-
# The loop below goes over the pairs of old and new package
2620-
# names. For each name there will be some checks done (like does
2621-
# this package even exist). Each name in the pair has a set of
2622-
# used slots associated with it (the most common situation is that
2623-
# each have just one slot, but there are some packages that we
2624-
# have multiple slots installed, like
2625-
# app-text/docbook-xml-dtd). Some of the slots will appear in both
2626-
# old and new package name, sometimes there will be slots
2627-
# available only in the old state or only in the new state. Each
2628-
# slot for each package name has an associated min version and max
2629-
# version. So for common slots we usually compare min version for
2630-
# old package with max version for new package. Any
2631-
# inconsistencies with the versions should be reported by
2632-
# now. There are some edge cases with the slots that are not
2633-
# handled by the automation - in such cases there will be a
2634-
# "manual action needed" report.
2635-
26362635
pkg_job_state_unset "${pkg_job_state_names[@]}"
26372636
bunch_of_maps_unset hpc_bunch_of_maps
26382637

0 commit comments

Comments
 (0)