coreos-modules: move mana kmod to commonconfig#2723
Merged
Conversation
This change moves CONFIG_MICROSOFT_MANA=m from amd64_defconfig-6.6 to commonconfig-6.6 to support the MANA network driver on ARM64 instances, too. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
force-pushed
the
t-lo/move-mana-kmod-to-commonconfig
branch
from
86a4d28 to
98ffef5
Compare
Contributor
|
How much does this increase the initrd size by, if anything? |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/13724252934 |
Member
Author
The kmod is about ~40kB. |
chewi
approved these changes
Mar 7, 2025
Member
Author
|
Build and test succeeded, reverting 98ffef5 and force-merging. |
t-lo
force-pushed
the
t-lo/move-mana-kmod-to-commonconfig
branch
from
98ffef5 to
bc47a32
Compare
t-lo
added a commit
that referenced
this pull request
Mar 7, 2025
coreos-modules: move mana kmod to commonconfig
t-lo
added a commit
that referenced
this pull request
Mar 7, 2025
coreos-modules: move mana kmod to commonconfig
t-lo
added a commit
that referenced
this pull request
Mar 7, 2025
coreos-modules: move mana kmod to commonconfig
t-lo
added a commit
that referenced
this pull request
Mar 7, 2025
coreos-modules: move mana kmod to commonconfig
Member
Author
|
Done. |
dongsupark
moved this to Implemented
in Flatcar tactical, release planning, and roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change moves
CONFIG_MICROSOFT_MANA=mfromamd64_defconfig-6.6tocommonconfig-6.6to support the MANA network driver on ARM64 instances, too.How to use
Build the OS image, launch a qemu aarch64 instance, check if the module loads.
Testing done
See "How to use".
Before merge
Remove commit 98ffef5 ; this was added because the last nightly SDK build did not complete, and today's SDK is not available - so we need to use yesterday's SDK.
Backport / Cherry-Pick
This change should be backported to all active maintenance branches, i.e. flatcar-4230, flatcar-4186, flatcar-4152, and flatcar-4081.