Skip to content

Commit 180029d

Browse files
committed
comments in spreadinterp re kernel eval writing to padded ns length
1 parent 46fd0b6 commit 180029d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/spreadinterp.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -468,6 +468,8 @@ int interpSorted(BIGINT* sort_indices,BIGINT N1, BIGINT N2, BIGINT N3,
468468
}
469469

470470
else{
471+
// due to ns being padded up to next multiple of 4 in the eval_kernel_vec_Horner
472+
// and writing zeros out to this padded size, these must occur in the order x,y,z...
471473
eval_kernel_vec_Horner(ker1,x1,ns,opts);
472474
if (ndims > 1) eval_kernel_vec_Horner(ker2,x2,ns,opts);
473475
if (ndims > 2) eval_kernel_vec_Horner(ker3,x3,ns,opts);
@@ -979,6 +981,8 @@ void spread_subproblem_2d(BIGINT off1,BIGINT off2,BIGINT size1,BIGINT size2,
979981
set_kernel_args(kernel_args+ns, x2, opts);
980982
evaluate_kernel_vector(kernel_values, kernel_args, opts, 2*ns);
981983
} else {
984+
// due to ns being padded up to next multiple of 4 in the eval_kernel_vec_Horner
985+
// and writing zeros out to this padded size, these must occur in the order x,y...
982986
eval_kernel_vec_Horner(ker1,x1,ns,opts);
983987
eval_kernel_vec_Horner(ker2,x2,ns,opts);
984988
}
@@ -1038,6 +1042,8 @@ void spread_subproblem_3d(BIGINT off1,BIGINT off2,BIGINT off3,BIGINT size1,
10381042
set_kernel_args(kernel_args+2*ns, x3, opts);
10391043
evaluate_kernel_vector(kernel_values, kernel_args, opts, 3*ns);
10401044
} else {
1045+
// due to ns being padded up to next multiple of 4 in the eval_kernel_vec_Horner
1046+
// and writing zeros out to this padded size, these must occur in the order x,y,z...
10411047
eval_kernel_vec_Horner(ker1,x1,ns,opts);
10421048
eval_kernel_vec_Horner(ker2,x2,ns,opts);
10431049
eval_kernel_vec_Horner(ker3,x3,ns,opts);

0 commit comments

Comments
 (0)