Skip to content

Commit 89a0797

Browse files
committed
fix kerevalmeth=0; temp fix python ci(retiring soon)
1 parent 4f6db34 commit 89a0797

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.github/workflows/python_build_win.ps1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ Add-Content -Path make.inc -Value "CXXFLAGS+= -march=x86-64"
1515
Set-Variable libvcruntime140_a -Value ([IO.Path]::Combine((Split-Path -Path $PYTHON), "libs", 'libvcruntime140.a'))
1616
Copy-Item -Path .\.github\workflows\libvcruntime140.a -Destination $libvcruntime140_a
1717

18-
python -m pip install --upgrade setuptools wheel numpy pip
18+
python -m pip install --upgrade setuptools==70.1.1 wheel numpy pip
1919
if (-not $?) {throw "Failed pip install"}
2020

2121
# mingw gcc compiler pacth to work with python

src/spreadinterp.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -739,6 +739,12 @@ void evaluate_kernel_vector(FLT *ker, FLT *args, const finufft_spread_opts &opts
739739
if (!(opts.flags & TF_OMIT_EVALUATE_EXPONENTIAL))
740740
for (int i = 0; i < Npad; i++) // Loop 2: Compute exponentials
741741
ker[i] = exp(ker[i]);
742+
if (opts.kerpad) {
743+
// padded part should be zero, in spread_subproblem_nd_kernels, there are
744+
// out of bound writes to trg arrays
745+
for (int i = N; i < Npad; ++i)
746+
ker[i] = 0.0;
747+
}
742748
} else {
743749
for (int i = 0; i < N; i++) // dummy for timing only
744750
ker[i] = 1.0;

tools/finufft/build-wheels-linux.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ versions=("cp36-cp36m"
2525
"cp310-cp310"
2626
"cp311-cp311"
2727
"cp312-cp312"
28-
"pp38-pypy38_pp73"
2928
"pp39-pypy39_pp73")
3029

3130
pys=()

0 commit comments

Comments
 (0)