Fix clippy errors

Author: barthalion

src/db.rs

@@ -156,9 +156,8 @@ impl Db {
             Ok(job)
         })
         .await
-        .map(|job| {
-            self.increment_queued_job_metric(&job);
-            job
+        .inspect(|job| {
+            self.increment_queued_job_metric(job);
         })
     }
 
@@ -258,9 +257,8 @@ impl Db {
             Ok(job)
         })
         .await
-        .map(|job| {
-            self.increment_queued_job_metric(&job);
-            job
+        .inspect(|job| {
+            self.increment_queued_job_metric(job);
         })
     }
 
@@ -289,9 +287,8 @@ impl Db {
             Ok(job)
         })
         .await
-        .map(|job| {
-            self.increment_queued_job_metric(&job);
-            job
+        .inspect(|job| {
+            self.increment_queued_job_metric(job);
         })
     }
 
@@ -308,9 +305,8 @@ impl Db {
                 .map_err(ApiError::from)
         })
         .await
-        .map(|job| {
-            self.increment_queued_job_metric(&job);
-            job
+        .inspect(|job| {
+            self.increment_queued_job_metric(job);
         })
     }
 

src/jobs/job_executor.rs

@@ -35,10 +35,12 @@ impl Actor for JobExecutor {
     type Context = SyncContext<Self>;
 }
 
+type QueuedJobInstance = (i16, Option<String>, Box<dyn JobInstance>);
+
 fn pick_next_job(
     executor: &mut JobExecutor,
     conn: &mut PgConnection,
-) -> Result<(i16, Option<String>, Box<dyn JobInstance>), DieselError> {
+) -> Result<QueuedJobInstance, DieselError> {
     use diesel::dsl::exists;
     use diesel::dsl::not;
     use diesel::dsl::now;
@@ -63,8 +65,7 @@ fn pick_next_job(
                     ),
                 )));
 
-            let mut new_instances: Vec<(i16, Option<String>, Box<dyn JobInstance>)> = match for_repo
-            {
+            let mut new_instances: Vec<QueuedJobInstance> = match for_repo {
                 None => jobs::table
                     .order(jobs::id)
                     .filter(ready_job_filter.and(jobs::repo.is_null()))

src/metrics.rs

@@ -37,12 +37,9 @@ impl Metrics {
         let jobs_queued = Family::<JobLabels, Gauge>::default();
         let job_duration_seconds =
             Family::<JobResultLabels, Histogram>::new_with_constructor(|| {
-                Histogram::new(
-                    [
-                        1.0, 5.0, 15.0, 30.0, 60.0, 120.0, 300.0, 600.0, 1800.0, 3600.0,
-                    ]
-                    .into_iter(),
-                )
+                Histogram::new([
+                    1.0, 5.0, 15.0, 30.0, 60.0, 120.0, 300.0, 600.0, 1800.0, 3600.0,
+                ])
             });
 
         flat_manager_registry.register(