Skip to content

Commit 0848ee3

Browse files
committed
node: drop node 14,16,18 in tests as runtime eof
1 parent dce29ad commit 0848ee3

File tree

1 file changed

+7
-9
lines changed

1 file changed

+7
-9
lines changed

node/tests/conftest.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def requests() -> Iterator[RequestsController]:
5656

5757

5858
_DEFAULT_MODULE = 'module'
59-
_DEFAULT_NODE = 16
59+
_DEFAULT_NODE = 20
6060

6161

6262
@dataclass
@@ -99,11 +99,9 @@ def build(
9999
sdk_extensions = []
100100
build_options = {}
101101
NODE_RUNTIME_VERSION_MAP = {
102-
'14': '22.08',
103-
'16': '22.08',
104-
'18': '22.08',
105-
'20': '24.08',
106-
'22': '24.08',
102+
'20': '25.08',
103+
'22': '25.08',
104+
'24': '25.08',
107105
}
108106

109107
if use_node:
@@ -121,9 +119,9 @@ def build(
121119
for i, command in enumerate(commands):
122120
commands[i] = f'. /usr/lib/sdk/node{use_node}/enable.sh && {command}'
123121

124-
runtime_version = NODE_RUNTIME_VERSION_MAP.get(use_node_str, '24.08')
122+
runtime_version = NODE_RUNTIME_VERSION_MAP.get(use_node_str, '25.08')
125123
else:
126-
runtime_version = '22.08'
124+
runtime_version = '25.08'
127125

128126
manifest = {
129127
'id': 'com.test.Test',
@@ -322,7 +320,7 @@ def provider_factory_spec(request: Any, shared_datadir: Path) -> ProviderFactory
322320
return ProviderFactorySpec(datadir=shared_datadir, type=type)
323321

324322

325-
@pytest.fixture(params=[14, 16, 18, 20, 22])
323+
@pytest.fixture(params=[20, 22, 24])
326324
def node_version(request: Any) -> int:
327325
version = request.param
328326
assert isinstance(version, int)

0 commit comments

Comments
 (0)