Skip to content

Commit 73cc1b9

Browse files
committed
poetry: Simplify some logic when looping over packages
1 parent 10827f3 commit 73cc1b9

File tree

1 file changed

+12
-20
lines changed

1 file changed

+12
-20
lines changed

poetry/flatpak-poetry-generator.py

Lines changed: 12 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -63,16 +63,12 @@ def get_module_sources(parsed_lockfile: dict, include_devel: bool = True) -> lis
6363
for section, packages in parsed_lockfile.items():
6464
if section == "package":
6565
for package in packages:
66-
if "category" not in package or (
67-
(
68-
package.get("category") == "dev"
69-
and include_devel
70-
and not package.get("optional")
71-
)
72-
or (
73-
package.get("category") == "main"
74-
and not package.get("optional")
75-
)
66+
category = package.get("category")
67+
optional = package.get("optional", False)
68+
if (
69+
not category
70+
or (category == "dev" and include_devel and not optional)
71+
or (category == "main" and not optional)
7672
):
7773
hashes = []
7874
# Check for old metadata format (poetry version < 1.0.0b2)
@@ -122,16 +118,12 @@ def get_dep_names(parsed_lockfile: dict, include_devel: bool = True) -> list:
122118
for section, packages in parsed_lockfile.items():
123119
if section == "package":
124120
for package in packages:
125-
if "category" not in package or (
126-
(
127-
package.get("category") == "dev"
128-
and include_devel
129-
and not package.get("optional")
130-
)
131-
or (
132-
package.get("category") == "main"
133-
and not package.get("optional")
134-
)
121+
category = package.get("category")
122+
optional = package.get("optional", False)
123+
if (
124+
not category
125+
or (category == "dev" and include_devel and not optional)
126+
or (category == "main" and not optional)
135127
):
136128
dep_names.append(package["name"])
137129
return dep_names

0 commit comments

Comments
 (0)