tests: Add test to catch duplicate build group in platform metadata

Author: bbhtt

tests/make-test-runtime.sh

@@ -28,6 +28,8 @@ PATH="$PATH:/usr/sbin:/sbin"
 # Add bash and dependencies
 mkdir -p ${DIR}/usr/bin
 mkdir -p ${DIR}/usr/lib
+mkdir -p ${DIR}/usr/share/runtime/locale/en
+echo "test" > ${DIR}/usr/share/runtime/locale/en/test
 ln -s ../lib ${DIR}/usr/lib64
 ln -s ../lib ${DIR}/usr/lib32
 if test -f /sbin/ldconfig.real; then

tests/meson.build

@@ -125,6 +125,7 @@ if get_option('installed_tests')
     'org.test.Hello-256.png',
     'org.flatpak.install_test.json',
     'test-locale-cleanup.json',
+    'test-runtime-platform.json',
 
     install_dir: installed_testdir,
     install_mode: 'rw-r--r--',

tests/test-builder.sh

@@ -23,7 +23,7 @@ set -euo pipefail
 
 skip_without_fuse
 
-echo "1..12"
+echo "1..13"
 
 setup_repo
 install_repo
@@ -41,6 +41,7 @@ cp $(dirname $0)/test-rename-appdata.json .
 cp $(dirname $0)/test.json .
 cp $(dirname $0)/test.yaml .
 cp $(dirname $0)/test-runtime.json .
+cp $(dirname $0)/test-runtime-platform.json .
 cp $(dirname $0)/0001-Add-test-logo.patch .
 cp $(dirname $0)/Hello.desktop .
 cp $(dirname $0)/Hello.xml .
@@ -139,6 +140,23 @@ ${FLATPAK_BUILDER} $FL_GPGARGS --repo=$REPO --force-clean runtimedir \
 
 echo "ok runtime build cleanup with build-args"
 
+${FLATPAK_BUILDER} $FL_GPGARGS --repo=$REPO --force-clean runtimedir \
+    test-runtime-platform.json >&2
+
+BUILD_GROUP_COUNT=$(grep -c '^\[Build\]' runtimedir/metadata.platform)
+if [ "$BUILD_GROUP_COUNT" -gt 1 ]; then
+    echo "not ok no duplicate [Build] groups in platform metadata"
+    exit 1
+fi
+
+BUILT_EXTENSIONS_COUNT=$(grep -c '^built-extensions=' runtimedir/metadata.platform)
+if [ "$BUILT_EXTENSIONS_COUNT" -gt 1 ]; then
+    echo "not ok duplicate built-extensions keys in platform metadata"
+    exit 1
+fi
+
+echo "ok no duplicate [Build] groups in platform metadata"
+
 # test screenshot ref commit
 ${FLATPAK_BUILDER} --repo=$REPO/repo_sc --force-clean builddir_sc \
     --mirror-screenshots-url=https://example.org/media \

tests/test-runtime-platform.json

@@ -0,0 +1,9 @@
+{
+    "build-runtime": true,
+    "id": "org.test.Hello.Sdk",
+    "id-platform": "org.test.Hello.Platform",
+    "runtime": "org.test.Platform",
+    "sdk": "org.test.Sdk",
+    "separate-locales": true,
+    "modules": []
+}