Add ability to set custom fusermount path

This also removes the 'fuse' option as it seems redundant.
.version().version_compare requires Meson >= 0.62.0 which is not
available in Ubuntu 22.04, so CI for that is dropped

Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>

Author: TingPing

.github/workflows/check.yml

@@ -23,7 +23,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: ['ubuntu-22.04', 'ubuntu-24.04']
+        os: ['ubuntu-24.04']
         compiler: ['gcc', 'clang']
 
     env:

NEWS

@@ -7,6 +7,7 @@ TBD
 * Drop autotools, the project now only supports building with meson
 * Prevent writing duplicate groups to metadata file
 * Disable all filesystem access in flatpak-builder --run sandbox
+* Add ability to set custom fusermount path
 
 Changes in 1.4.6
 ================

meson.build

@@ -2,7 +2,7 @@ project(
   'flatpak-builder',
   'c',
   license: 'LGPL-2.1-or-later',
-  meson_version: '>= 0.56.2',
+  meson_version: '>= 0.62.0',
   version: '1.5.0',
   default_options: 'c_std=gnu99',
 )
@@ -44,6 +44,13 @@ debugedit = find_program('debugedit', version: '>= 5.0')
 appstreamcli = find_program('appstreamcli', version: '>= 0.15.0')
 appstreamcli_compose = run_command(appstreamcli, ['compose', '--help'], check: true)
 
+fusermount = get_option('system_fusermount')
+if fusermount == ''
+  fusermount_program = find_program(['fusermount3', 'fusermount'], required: true)
+else
+  fusermount_program = find_program(fusermount, required: true)
+endif
+
 subdir('src')
 subdir('doc')
 if get_option('tests')

meson_options.txt

@@ -23,9 +23,8 @@ option(
   description: 'Whether to build and run unit tests'
 )
 option(
-  'fuse',
-  type: 'combo',
-  choices: ['2', '3', 'compatible'],
-  value: 'compatible',
-  description: 'Target a specific version of FUSE for best performance or support multiple versions'
+  'system_fusermount',
+  type: 'string',
+  description: 'system fusermount executable, or empty string to try multiple names (fusermount3, fusermount) automatically',
+  value: '',
 )

src/builder-context.c

@@ -854,8 +854,7 @@ static char *rofiles_unmount_path = NULL;
 static void
 rofiles_umount_handler (int signum)
 {
-  char *argv[] = { "fusermount", "-uz", NULL,
-                     NULL };
+  char *argv[] = { FUSERMOUNT, "-uz", NULL, NULL };
 
   argv[2] = rofiles_unmount_path;
   g_debug ("Unmounting read-only fs: %s %s %s", argv[0], argv[1], argv[2]);
@@ -994,8 +993,7 @@ gboolean
 builder_context_disable_rofiles (BuilderContext *self,
                                  GError        **error)
 {
-  char *argv[] = { "fusermount", "-u", NULL,
-                     NULL };
+  char *argv[] = { FUSERMOUNT, "-u", NULL, NULL };
 
   if (!self->use_rofiles)
     return TRUE;

src/meson.build

@@ -39,7 +39,8 @@ config_data.set('GLIB_VERSION_MIN_REQUIRED', 'GLIB_VERSION_2_66')
 # We support targeting specific fuse versions to optimize performance.
 # Currently only fuse2 has optimizations but this allows for future fuse3
 # optimizations.
-config_data.set('ASSUME_FUSE_2', get_option('fuse') == '2')
+config_data.set('ASSUME_FUSE_2', fusermount_program.version().version_compare('< 3.0.0'))
+config_data.set_quoted('FUSERMOUNT', fusermount_program.full_path())
 
 config_h = configure_file(
   configuration: config_data,

tests/installed-tests.sh.in

@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: LGPL-2.1-or-later
+
+FUSERMOUNT='@FUSERMOUNT@'

tests/libtest.sh

@@ -30,6 +30,14 @@ else
   test_builddir=$(dirname $0)
 fi
 
+if [ -e "$test_srcdir/installed-tests.sh" ]; then
+    . "$test_srcdir/installed-tests.sh"
+fi
+
+if [ -z "${FUSERMOUNT}" ]; then
+  FUSERMOUNT=fusermount
+fi
+
 assert_not_reached () {
     echo $@ 1>&2; exit 1
 }
@@ -296,7 +304,7 @@ run_sh () {
 # fuse support is needed (and the kernel module needs to be loaded) for several
 # flatpak-builder tests
 skip_without_fuse () {
-    if [ ! -w /dev/fuse ] || ! command -v fusermount >/dev/null; then
+    if [ ! -w /dev/fuse ] || ! command -v "$FUSERMOUNT" >/dev/null; then
         echo "1..0 # SKIP this test requires fuse support"
         exit 0
     fi

tests/meson.build

@@ -6,6 +6,7 @@ test_env.set('FLATPAK_TESTS_DEBUG', '1')
 test_env.set('G_TEST_SRCDIR', meson.current_source_dir())
 test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
 test_env.prepend('PATH', meson.current_build_dir() / '..' / 'src', separator: ':')
+test_env.set('FUSERMOUNT', fusermount_program.full_path())
 
 test_names = [
   'test-builder',
@@ -17,6 +18,17 @@ tap_test = find_program(
   files(meson.project_source_root() / 'buildutil/tap-test'),
 )
 
+if get_option('installed_tests')
+  configure_file(
+    input : 'installed-tests.sh.in',
+    output : 'installed-tests.sh',
+    configuration : {
+      'FUSERMOUNT' : fusermount_program.full_path(),
+    },
+    install_dir : installed_testdir,
+  )
+endif
+
 foreach test_name : test_names
   filename = test_name + '.sh'