Skip to content

Commit f4d6b61

Browse files
committed
tests: Drop screenshots from metainfo
This aren't required since the test is checking for the presence of a mirrored icon link. Appstream tries to download screenshots if present and ignores download failures anyway silently. This may be contributing to the flakiness in [1]. Since the test already works offline, the screenshot links are redundant [1]: #714 (comment)
1 parent 5fff033 commit f4d6b61

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

tests/org.flatpak_builder.gui.metainfo.xml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -11,22 +11,6 @@
1111
<description>
1212
<p>An example desktop application</p>
1313
</description>
14-
<screenshots>
15-
<!-- appstream silently continues without error if the file fails to
16-
download. since the tag only accepts http(s) urls, we add
17-
multiple sources so that in case one link fails, at least one
18-
of the other ones work. Replace with any other screenshot
19-
link if it fails
20-
-->
21-
<screenshot type="default">
22-
<caption>An example screenshot</caption>
23-
<image>https://raw.githubusercontent.com/flatpak/flatpak.github.io/0b56895e271bbcc7f86f9570933a96adff99e110/source/img/endless-apps.original.png</image>
24-
</screenshot>
25-
<screenshot>
26-
<caption>An example screenshot</caption>
27-
<image>https://docs.flathub.org/img/card.png</image>
28-
</screenshot>
29-
</screenshots>
3014
<url type="bugtracker">https://flatpak.org</url>
3115
<content_rating type="oars-1.1"/>
3216
<releases>

0 commit comments

Comments
 (0)