Skip to content

Commit 2da077a

Browse files
Apply suggestions from code review
Co-authored-by: Bilal Elmoussaoui <[email protected]>
1 parent 7f64eec commit 2da077a

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ jobs:
103103
manifest-path: org.gnome.zbrown.Palette.yml
104104
cache-key: flatpak-builder-${{ github.sha }}
105105
arch: ${{ matrix.arch }}
106-
# if you want to upload flatpak bundle to release tag e.g. 1.2.3, add this line:
106+
# if you want to upload Flatpak bundle to a release tag e.g. 1.2.3
107107
github-tag: 1.2.3
108108
```
109109

flatpak-builder/index.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ class Configuration {
6060
this.verbose = core.getBooleanInput('verbose')
6161
// Upload the artifact
6262
this.uploadArtifact = core.getBooleanInput('upload-artifact')
63-
// Upload to which tag of GitHub
63+
// Upload the artifact to a GitHub tag
6464
this.gitHubTag = core.getInput('github-tag')
6565
}
6666

@@ -258,14 +258,14 @@ const build = async (manifest, manifestPath, cacheHitKey, config) => {
258258
}
259259

260260
if ((config.gitHubTag !== "") && config.buildBundle) {
261-
core.info(`Upload .flatpak file to GitHub(TAG: ${config.gitHubTag}, BUNDLE: ${config.bundle})...`)
261+
core.info(`Uploadading ${config.bundle} to GitHub tag ${config.gitHubTag}...`)
262262
const ghArgs = [
263-
`release`,
264-
`upload`,
263+
'release',
264+
'upload',
265265
config.gitHubTag,
266266
config.bundle,
267-
`--repo`,
268-
`$GITHUB_REPOSITORY`
267+
'--repo',
268+
'$GITHUB_REPOSITORY'
269269
]
270270

271271
const exitCodeUploadToGithub = await exec.exec('gh', ghArgs, {

0 commit comments

Comments
 (0)