Skip to content

Commit e625d71

Browse files
committed
add .c_str() to log calls
1 parent d181625 commit e625d71

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

firmware/src/widgets/mqttwidget/MQTTWidget.cpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ void MQTTWidget::setup() {
125125

126126
// Update method
127127
void MQTTWidget::update(bool force) {
128-
// Log.traceln("Inside update method - " + String(mqttClient.connected()));
128+
// Log.traceln("Inside update method - %s" + mqttClient.connected().c_str());
129129

130130
if (!mqttClient.connected()) {
131131
reconnect();
@@ -205,7 +205,7 @@ void MQTTWidget::callback(char *topic, byte *payload, unsigned int length) {
205205
if (fieldValue.is<JsonArray>()) {
206206
fieldValue = fieldValue[index]; // Access the array element by index
207207
} else {
208-
Log.errorln("Error: Expected an array for %s", String(token));
208+
Log.errorln("Error: Expected an array for %s", token);
209209
return;
210210
}
211211
} else {
@@ -235,32 +235,32 @@ void MQTTWidget::callback(char *topic, byte *payload, unsigned int length) {
235235

236236
// Update the display only if the value has actually changed
237237
it->second = extractedValue;
238-
Log.traceln("Parsed %s : %s", orb->jsonField, extractedValue);
238+
Log.traceln("Parsed %s : %s", orb->jsonField.c_str(), extractedValue.c_str());
239239

240240
// Redraw the orb with updated data
241241
drawOrb(orb->orbid);
242242
} else {
243-
Log.traceln("No change detected for field: %s", orb->jsonField);
243+
Log.traceln("No change detected for field: %s", orb->jsonField.c_str());
244244
}
245245
} else {
246-
Log.warningln("JSON field '%s' not found in payload.", orb->jsonField);
246+
Log.warningln("JSON field '%s' not found in payload.", orb->jsonField.c_str());
247247
return;
248248
}
249249
} else {
250250
// The orb does not expect a JSON field; use the entire payload
251251
if (it->second != message) {
252252
it->second = message;
253-
Log.traceln("Updated data for %s : %s", receivedTopic, message);
253+
Log.traceln("Updated data for %s : %s", receivedTopic.c_str(), message.c_str());
254254
drawOrb(orb->orbid);
255255
} else {
256-
Log.traceln("No change detected for topic: %s", receivedTopic);
256+
Log.traceln("No change detected for topic: %s", receivedTopic.c_str());
257257
}
258258
}
259259
} else {
260-
Log.warningln("No orb configuration found for topic: %s", receivedTopic);
260+
Log.warningln("No orb configuration found for topic: %s", receivedTopic.c_str());
261261
}
262262
} else {
263-
Log.traceln("Received message for unknown topic: %s", receivedTopic);
263+
Log.traceln("Received message for unknown topic: %s", receivedTopic.c_str());
264264
}
265265
}
266266
}
@@ -310,7 +310,7 @@ void MQTTWidget::handleSetupMessage(const String &message) {
310310
config.orbTextColor = getColorFromString(textColorStr);
311311

312312
orbConfigs.push_back(config);
313-
Log.infoln("Configured Orb: %s -> %s", String(config.orbid), config.orbdesc);
313+
Log.infoln("Configured Orb: %d -> %s", config.orbid, config.orbdesc.c_str());
314314

315315
// Initialize data map with empty strings
316316
orbDataMap[config.topicSrc] = "";
@@ -382,7 +382,7 @@ void MQTTWidget::reconnect() {
382382
Log.warningln("Failed to subscribe to setup topic: %s", mqttSetupTopic.c_str());
383383
}
384384
} else {
385-
Log.warningln("failed, rc=%s", String(mqttClient.state()));
385+
Log.warningln("failed, rc=%d", mqttClient.state());
386386
Log.warningln("try again in 5 seconds");
387387
}
388388
}
@@ -405,7 +405,7 @@ void MQTTWidget::drawOrb(int orbid) {
405405
}
406406

407407
if (orb == nullptr) {
408-
Log.warningln("Orb not found for orbid: %s", String(orbid));
408+
Log.warningln("Orb not found for orbid: %d", orbid);
409409
return;
410410
}
411411

0 commit comments

Comments
 (0)