Skip to content

Commit 1e240a0

Browse files
committed
Fix face merging for display strings broken by a recent commit
* src/xfaces.c (face_at_string_position): Revert the last change, as it cannot possibly solve bug#38563. * src/xdisp.c (face_at_pos): Fix a typo made during last change here, which broke face merging for display strings. (Bug#38633)
1 parent 5aab1e8 commit 1e240a0

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

src/xdisp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4243,7 +4243,7 @@ face_at_pos (const struct it *it, enum lface_attribute_index attr_filter)
42434243
the display string do. This sounds like a design bug,
42444244
but Emacs always did that since v21.1, so changing that
42454245
might be a big deal. */
4246-
base_face_id = it->string_from_display_prop_p
4246+
base_face_id = it->string_from_prefix_prop_p
42474247
? (!NILP (Vface_remapping_alist)
42484248
? lookup_basic_face (it->w, it->f, DEFAULT_FACE_ID)
42494249
: DEFAULT_FACE_ID)

src/xfaces.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6446,10 +6446,6 @@ face_at_string_position (struct window *w, Lisp_Object string,
64466446

64476447
/* Begin with attributes from the base face. */
64486448
memcpy (attrs, base_face->lface, sizeof attrs);
6449-
/* Reset the attribute of the base face used as the filter, because
6450-
otherwise there's no way for faces to be merged to countermand that. */
6451-
if (EQ (attrs[attr_filter], Qt))
6452-
attrs[attr_filter] = Qnil;
64536449

64546450
/* Merge in attributes specified via text properties. */
64556451
if (!NILP (prop))

0 commit comments

Comments
 (0)