Revert "Don't complain about the regexp "[:-:]""

This reverts commit 3766bf7.

Author: mattiase

src/regex-emacs.c

@@ -2007,7 +2007,7 @@ regex_compile (re_char *pattern, ptrdiff_t size,
             if (*p == ':')
               {
                 re_char *q = p + 1;
-                while (q != pend && *q != ']' && *q != '-')
+                while (q != pend && *q != ']')
                   {
                     if (*q == ':')
                       {

test/src/regex-emacs-tests.el

@@ -806,7 +806,6 @@ This evaluates the TESTS test cases from glibc."
 (ert-deftest regexp-invalid ()
   ;; relint suppression: Duplicated
   (should-error (string-match "[:space:]" "")
-                :type 'invalid-regexp)
-  (should (equal (string-match "[:-:]" "a-:") 2)))
+                :type 'invalid-regexp))
 
 ;;; regex-emacs-tests.el ends here