Skip to content

Commit f373cec

Browse files
committed
Fix uses of inhibit-message in package.el
* lisp/emacs-lisp/package.el (package-generate-autoloads) (package--compile, package--save-selected-packages): Don't use 'inhibit-message' to bind 'noninteractive' and 'save-silently', since 'inhibit-message' already disables all messages. (Bug#38264)
1 parent f9b8c74 commit f373cec

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

lisp/emacs-lisp/package.el

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1002,8 +1002,6 @@ untar into a directory named DIR; otherwise, signal an error."
10021002
(generated-autoload-file (expand-file-name auto-name pkg-dir))
10031003
;; We don't need 'em, and this makes the output reproducible.
10041004
(autoload-timestamps nil)
1005-
;; Silence `autoload-generate-file-autoloads'.
1006-
(noninteractive inhibit-message)
10071005
(backup-inhibited t)
10081006
(version-control 'never))
10091007
(package-autoload-ensure-default-file generated-autoload-file)
@@ -1029,7 +1027,6 @@ untar into a directory named DIR; otherwise, signal an error."
10291027
This assumes that `pkg-desc' has already been activated with
10301028
`package-activate-1'."
10311029
(let ((warning-minimum-level :error)
1032-
(save-silently inhibit-message)
10331030
(load-path load-path))
10341031
(byte-recompile-directory (package-desc-dir pkg-desc) 0 t)))
10351032

@@ -1840,8 +1837,7 @@ Used to populate `package-selected-packages'."
18401837
(when value
18411838
(setq package-selected-packages value))
18421839
(if after-init-time
1843-
(let ((save-silently inhibit-message))
1844-
(customize-save-variable 'package-selected-packages package-selected-packages))
1840+
(customize-save-variable 'package-selected-packages package-selected-packages)
18451841
(add-hook 'after-init-hook #'package--save-selected-packages)))
18461842

18471843
(defun package--user-selected-p (pkg)

0 commit comments

Comments
 (0)