-
-
Notifications
You must be signed in to change notification settings - Fork 893
fix: make horizontal repetition CRS dependent #1978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
New file: * `epsg3006_crs.dart`: new example around EPSG3006, needed for tests Impacted files: * `camera.dart`: special case around `replicatesWorldLongitude` * `crs.dart`: new `bool` getter `replicatesWorldLongitude` * `main.dart`: added EPSG3006 example * `map_interactive_viewer.dart`: special case around `replicatesWorldLongitude` * `menu_drawer.dart`: added EPSG3006 example * `tile_coordinates.dart`: moved code to new class `TileCoordinatesSimplifier` * `tile_image_manager.dart`: now using a `TileCoordinatesSimplifier` for more flexibility * `tile_image_view.dart`: now using a `TileCoordinatesSimplifier` for more flexibility * `tile_layer.dart`: special case around `replicatesWorldLongitude` * `tile_range.dart`: special case around `replicatesWorldLongitude`
|
This branch works well in my application. Still think the |
Cool!
@arneke You're right: I've just fixed that. Thank you for your meticulous review! |
JaffaKetchup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long wait, had a busy week!
JaffaKetchup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Sorry for the wait, I've had a hugely busy few weeks!)
I think I'm OK with this, but would appreciate a review from someone else!
|
Thank you @JaffaKetchup for your review! |
josxha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the feeling that the fling animation has stutters when using a map with longitude repetition. Most notifable when crossing the -180/180 longitude. Could anyone check if it happens to them as well?
Impacted files: * tile_coordinates.dart: renamed as TileCoordinatesResolver and made const * tile_image_manager.dart: removed the immutable metatag; used a setter and refactored * tile_image_view.dart: refactored with a non null resolver * tile_layer.dart: using a setter instead
Impacted files: * tile_coordinates.dart: renamed as TileCoordinatesResolver and made const * tile_image_manager.dart: removed the immutable metatag; used a setter and refactored * tile_image_view.dart: refactored with a non null resolver * tile_layer.dart: using a setter instead
|
@JaffaKetchup @josxha Actually |
I suspect that my latest push made things slightly faster, with |
|
Do you know why the map is offset between zoom level 1 and 2? recoding.mp4 |
josxha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the example page, solves my open points. 😄
Looks good! Thanks for the contribution.
|
@JaffaKetchup @josxha Thank you for your reviews and comments! Still, there seems to be an issue with the "Build Android Example App" CI/CD. A bit cryptic to me: maybe the gradle version, maybe the android ndk version. |
What
Files
New file:
epsg3006_crs.dart: new example around EPSG3006, needed for testsImpacted files:
camera.dart: special case aroundreplicatesWorldLongitudecrs.dart: newboolgetterreplicatesWorldLongitudemain.dart: added EPSG3006 examplemap_interactive_viewer.dart: special case aroundreplicatesWorldLongitudemenu_drawer.dart: added EPSG3006 exampletile_coordinates.dart: moved code to new classTileCoordinatesSimplifiertile_image_manager.dart: now using aTileCoordinatesSimplifierfor more flexibilitytile_image_view.dart: now using aTileCoordinatesSimplifierfor more flexibilitytile_layer.dart: special case aroundreplicatesWorldLongitudetile_range.dart: special case aroundreplicatesWorldLongitude