fix: ensure MapController.rotateAroundPoint does not move map when already rotated
#2029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaffaKetchup
changed the title
MapController.rotateAroundPoint does not move map when already rotated
Contributor
Author
|
Thanks for the quick response! The flutter_map_location_marker plugin relies heavily on this particular method addressed in the PR, so this fix is very important for its functionality. Do you have an estimated timeline for when this patch might be published? Knowing that would be extremely helpful for planning updates to the plugin. Thanks again! |
Member
|
I'll try to push a patch version ASAP, maybe tomorrow. |
This comment has been minimized.
This comment has been minimized.
This comment was marked as spam.
This comment was marked as spam.
This comment has been minimized.
This comment has been minimized.
Member
|
Sorry for the wait, we've been able to merge for about a week (were waiting for another PR), but we got a little busy. We've just release v8.1.0 with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2028