Skip to content

Commit e542004

Browse files
#52 Remove entityQueryResult undefining on query change to fix inspector flicker
* Remove entityQueryResult undefining on query change to fix inspector flicker * Add undefining entityQueryResult in entity lookup error handler * Unset entityQueryResult name so computed name shows in inspector.
1 parent 2cbf7d0 commit e542004

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

etc/js/components/widgets/inspector/entity-inspector-container.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ const entityBrief = computed(() => {
113113
});
114114
115115
const entityName = computed(() => {
116-
if (props.entityQueryResult) {
116+
if (props.entityQueryResult && props.entityQueryResult.name !== undefined) {
117117
return props.entityQueryResult.name;
118118
} else {
119119
return explorer.shortenEntity(props.path)
@@ -212,4 +212,4 @@ div.entity-inspector-no-result {
212212
color: var(--secondary-text);
213213
}
214214
215-
</style>
215+
</style>

etc/js/components/widgets/inspector/entity-inspector.vue

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,9 @@ function updateQuery() {
294294
295295
if (lastQuery) {
296296
lastQuery.abort();
297-
entityQueryResult.value = undefined;
297+
if (entityQueryResult.value && entityQueryResult.value.name) {
298+
entityQueryResult.value.name = undefined;
299+
}
298300
}
299301
300302
if (props.path) {
@@ -410,6 +412,7 @@ function updateQuery() {
410412
},
411413
(err) => {
412414
loading.value = true;
415+
entityQueryResult.value = undefined;
413416
},
414417
(request) => {
415418
loading.value = true;

0 commit comments

Comments
 (0)