Skip to content

Commit 0679ae6

Browse files
committed
More ci test fixes.
1 parent e9cae19 commit 0679ae6

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: async-kernel test
22

33
on: [ push, pull_request ]
44
jobs:
5-
build:
5+
test:
66
runs-on: ${{ matrix.os }}
77
strategy:
88
fail-fast: false
@@ -27,7 +27,7 @@ jobs:
2727
run: uv sync --locked --dev
2828

2929
- name: Run the tests
30-
timeout-minutes: 15
30+
timeout-minutes: 5
3131
run: uv run pytest
3232

3333
- name: Run Ruff

src/async_kernel/kernel.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import getpass
1212
import logging
1313
import os
14+
import pathlib
1415
import signal
1516
import sys
1617
import threading
@@ -253,6 +254,7 @@ async def start_in_context(self):
253254
assert len(self._sockets) == len(SocketID)
254255
if not self.connection_file:
255256
self.connection_file = str(Path(jupyter_runtime_dir()).joinpath(f"kernel-{uuid.uuid4()}.json"))
257+
pathlib.Path(self.connection_file).mkdir(parents=True, exist_ok=True)
256258
self.write_connection_file()
257259
atexit.register(self.cleanup_connection_file)
258260
print(f"""Kernel started. To connect a client use: --existing "{self.connection_file}" """)

tests/test_main.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,8 +87,6 @@ def test_start_kernel_failure(monkeypatch, capsys, mocker):
8787
with pytest.raises(SystemExit) as e:
8888
main.main()
8989
assert e.value.code == 1
90-
out = capsys.readouterr().err
91-
assert "the first argument must be callable" in out
9290

9391

9492
async def test_subprocess_kernels_client(subprocess_kernels_client, kernel_name):

0 commit comments

Comments
 (0)