Tabs completed

Author: FeodorFitsner

client/lib/controls/tabs.dart

@@ -27,7 +27,8 @@ class TabsControl extends StatefulWidget {
 }
 
 class _TabsControlState extends State<TabsControl>
-    with SingleTickerProviderStateMixin {
+    with TickerProviderStateMixin {
+  int _tabsCount = 0;
   List<String> _tabsIndex = [];
   String? _value;
   TabController? _tabController;
@@ -36,7 +37,8 @@ class _TabsControlState extends State<TabsControl>
   void initState() {
     super.initState();
     _tabsIndex = widget.children.map((c) => c.attrString("key", "")!).toList();
-    _tabController = TabController(length: widget.children.length, vsync: this);
+    _tabsCount = widget.children.length;
+    _tabController = TabController(length: _tabsCount, vsync: this);
     _tabController!.addListener(() {
       if (_tabController!.indexIsChanging == true) {
         return;
@@ -53,6 +55,11 @@ class _TabsControlState extends State<TabsControl>
   Widget build(BuildContext context) {
     debugPrint("TabsControl build: ${widget.control.id}");
 
+    if (widget.children.length != _tabsCount) {
+      _tabsCount = widget.children.length;
+      _tabController = TabController(length: _tabsCount, vsync: this);
+    }
+
     bool disabled = widget.control.isDisabled || widget.parentDisabled;
 
     String? value = widget.control.attrString("value");

sdk/python/playground/tabs-test.py

@@ -46,8 +46,30 @@ def main(page: Page):
     page.update()
     sleep(3)
     t.value = "tab2"
+    t.tabs.pop(0)
     t.tabs[1].content = Text("Blah blah blah")
     page.update()
+    sleep(3)
+    t.tabs.clear()
+    page.update()
+    sleep(3)
+    t.tabs.append(
+        Tab(
+            key="tab4",
+            text="Tab 4",
+            icon=icons.LOCK,
+            content=Text("This is Tab 4"),
+        )
+    )
+    t.tabs.append(
+        Tab(
+            key="tab5",
+            text="Tab 5",
+            icon=icons.SIP_SHARP,
+            content=Text("This is Tab 5"),
+        )
+    )
+    page.update()
 
 
 flet.app(