Replace more assertions with if-raise conditions (#5721)

* initial commit

* Replace assertions with appropriate exceptions for better error handling.

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* improve docstrings

---------

Co-authored-by: Feodor Fitsner <[email protected]>
Co-authored-by: Copilot <[email protected]>

Author: 3 people

packages/flet/lib/src/utils/drawing.dart

@@ -40,12 +40,11 @@ List<double>? parsePaintStrokeDashPattern(dynamic value,
     [List<double>? defaultValue]) {
   if (value == null) return defaultValue;
 
-  return value["stroke_dash_pattern"] != null
-      ? (value["stroke_dash_pattern"] as List)
-          .map((e) => parseDouble(e))
+  return (value["stroke_dash_pattern"] as List?)
+          ?.map((e) => parseDouble(e))
           .nonNulls
-          .toList()
-      : null;
+          .toList() ??
+      defaultValue;
 }
 
 ui.Gradient? parsePaintGradient(Map<dynamic, dynamic>? value, ThemeData? theme,

sdk/python/packages/flet-ads/src/flet_ads/banner_ad.py

@@ -11,7 +11,8 @@ class BannerAd(BaseAd):
     Displays a banner ad.
 
     Raises:
-        AssertionError: When this control is used on a web and/or non-mobile platform.
+        FletUnsupportedPlatformException: When this control is used on a web
+            and/or non-mobile platform.
     """
 
     on_will_dismiss: Optional[ft.ControlEventHandler["BannerAd"]] = None

sdk/python/packages/flet-ads/src/flet_ads/base_ad.py

@@ -11,7 +11,8 @@ class BaseAd(ft.Control):
     Base class for all ad controls in Flet Ads package.
 
     Raises:
-        AssertionError: When using this control on a web and/or non-mobile platform.
+        FletUnsupportedPlatformException: When using this control on a web
+            and/or non-mobile platform.
     """
 
     unit_id: str
@@ -63,6 +64,8 @@ class BaseAd(ft.Control):
     """
 
     def before_update(self):
-        assert not self.page.web and self.page.platform.is_mobile(), (
-            f"{self.__class__.__name__} is only supported on Mobile (Android and iOS)"
-        )
+        if self.page.web or not self.page.platform.is_mobile():
+            raise ft.FletUnsupportedPlatformException(
+                f"{self.__class__.__name__} is only supported on "
+                f"Mobile (Android and iOS)"
+            )

sdk/python/packages/flet-ads/src/flet_ads/interstitial_ad.py

@@ -8,7 +8,8 @@ class InterstitialAd(BaseAd):
     Displays a full-screen interstitial ad.
 
     Raises:
-        AssertionError: When using this control on a web and/or non-mobile platform.
+        FletUnsupportedPlatformException: When using this control on a
+            web and/or non-mobile platform.
     """
 
     async def show(self):

sdk/python/packages/flet-ads/src/flet_ads/native_ad.py

@@ -9,24 +9,25 @@
 class NativeAd(BannerAd):
     """
     Renders a native ad.
-
-    Raises:
-        AssertionError: When neither [`factory_id`][(c).] nor
-            [`template_style`][(c).] is set.
     """
 
     factory_id: str = None
     """
     An identifier for the factory that creates the Platform view.
+
+    Raises:
+        ValueError: When neither `factory_id` nor [`template_style`][(c).] is set.
     """
 
     template_style: NativeAdTemplateStyle = None
     """
     A style for the native ad template.
+
+    Raises:
+        ValueError: When neither [`factory_id`][(c).] nor `template_style` is set.
     """
 
     def before_update(self):
         super().before_update()
-        assert self.factory_id is not None or self.template_style is not None, (
-            "factory_id or template_style must be set"
-        )
+        if self.factory_id is None and self.template_style is None:
+            raise ValueError("factory_id or template_style must be set")

sdk/python/packages/flet-audio-recorder/src/flet_audio_recorder/audio_recorder.py

@@ -54,10 +54,12 @@ async def start_recording(
 
         Returns:
             `True` if recording was successfully started, `False` otherwise.
+
+        Raises:
+            ValueError: If `output_path` is not provided on platforms other than web.
         """
-        assert self.page.web or output_path, (
-            "output_path must be provided on platforms other than web"
-        )
+        if not (self.page.web or output_path):
+            raise ValueError("output_path must be provided on platforms other than web")
         return await self._invoke_method(
             method_name="start_recording",
             arguments={

sdk/python/packages/flet-audio/src/flet_audio/audio.py

@@ -27,7 +27,7 @@ class Audio(ft.Service):
             is a list of supported audio formats.
 
     Raises:
-        AssertionError: If both [`src`][(c).] and [`src_base64`][(c).] are `None`.
+        ValueError: If both `src` and [`src_base64`][(c).] are `None`.
     """
 
     src_base64: Optional[str] = None
@@ -41,7 +41,7 @@ class Audio(ft.Service):
             is a list of supported audio formats.
 
     Raises:
-        AssertionError: If both [`src`][(c).] and [`src_base64`][(c).] are `None`.
+        ValueError: If both `src_base64` and [`src`][(c).] are `None`.
     """
 
     autoplay: bool = False
@@ -118,7 +118,8 @@ class Audio(ft.Service):
 
     def before_update(self):
         super().before_update()
-        assert self.src or self.src_base64, "either src or src_base64 must be provided"
+        if not (self.src or self.src_base64):
+            raise ValueError("either src or src_base64 must be provided")
 
     async def play(self, position: ft.DurationValue = 0):
         """

sdk/python/packages/flet-charts/src/flet_charts/bar_chart.py

@@ -175,15 +175,15 @@ class BarChart(ft.LayoutControl):
 
     group_spacing: ft.Number = 16.0
     """
-    A amount of space between bar [`groups`][..].
+    An amount of space between bar [`groups`][(c).].
     """
 
     group_alignment: ft.MainAxisAlignment = ft.MainAxisAlignment.SPACE_EVENLY
     """
-    The alignment of the bar [`groups`][..] within this chart.
+    The alignment of the bar [`groups`][(c).] within this chart.
 
     If set to [`MainAxisAlignment.CENTER`][flet.MainAxisAlignment.CENTER],
-    the space between the `groups` can be specified using [`group_spacing`][..].
+    the space between the `groups` can be specified using [`group_spacing`][(c).].
     """
 
     animation: ft.AnimationValue = field(

sdk/python/packages/flet-charts/src/flet_charts/chart_axis.py

@@ -19,7 +19,7 @@ class ChartAxisLabel(ft.BaseControl):
 
     label: Optional[ft.StrOrControl] = None
     """
-    The label to display for the specified [`value`][..].
+    The label to display for the specified [`value`][(c).].
     """
 
 
@@ -41,7 +41,7 @@ class ChartAxis(ft.BaseControl):
 
     show_labels: bool = True
     """
-    Whether to display the [`labels`][..] along the axis.
+    Whether to display the [`labels`][(c).] along the axis.
     If `labels` is empty then automatic labels are displayed.
     """
 
@@ -61,7 +61,7 @@ class ChartAxis(ft.BaseControl):
 
     label_size: ft.Number = 22
     """
-    The maximum space for each label in [`labels`][..].
+    The maximum space for each label in [`labels`][(c).].
 
     Each label will stretch to fit this space.
     """

sdk/python/packages/flet-charts/src/flet_charts/line_chart_data.py

@@ -48,7 +48,7 @@ class LineChartData(ft.BaseControl):
 
     prevent_curve_over_shooting_threshold: ft.Number = 10.0
     """
-    Threshold for [`prevent_curve_over_shooting`][..] algorithm.
+    Threshold for [`prevent_curve_over_shooting`][(c).] algorithm.
     """
 
     dash_pattern: Optional[list[int]] = None
@@ -131,7 +131,7 @@ class LineChartData(ft.BaseControl):
     curve_smoothness: ft.Number = 0.35
     """
     Defines the smoothness of a curve line,
-    when [`curved`][..] is set to `True`.
+    when [`curved`][(c).] is set to `True`.
     """
 
     rounded_stroke_join: bool = False