Skip to content

Commit 831342c

Browse files
Fixes for Gallery (#351)
* Icon, Column -> constrained control * Do not use input() to block the script on Windows Fix #314 * Disable websocket logging completely Fix #321
1 parent 409acf9 commit 831342c

File tree

6 files changed

+51
-10
lines changed

6 files changed

+51
-10
lines changed

package/lib/src/controls/icon.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class IconControl extends StatelessWidget {
2121
var color = HexColor.fromString(
2222
Theme.of(context), control.attrString("color", "")!);
2323

24-
return baseControl(
24+
return constrainedControl(
2525
Icon(
2626
getMaterialIcon(name),
2727
size: size,

sdk/python/flet/column.py

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
ScrollMode,
1212
)
1313
from flet.ref import Ref
14+
from flet.types import AnimationValue, OffsetValue, RotateValue, ScaleValue
1415

1516

1617
class Column(ConstrainedControl):
@@ -26,6 +27,15 @@ def __init__(
2627
bottom: OptionalNumber = None,
2728
expand: Union[None, bool, int] = None,
2829
opacity: OptionalNumber = None,
30+
rotate: RotateValue = None,
31+
scale: ScaleValue = None,
32+
offset: OffsetValue = None,
33+
animate_opacity: AnimationValue = None,
34+
animate_size: AnimationValue = None,
35+
animate_position: AnimationValue = None,
36+
animate_rotation: AnimationValue = None,
37+
animate_scale: AnimationValue = None,
38+
animate_offset: AnimationValue = None,
2939
visible: Optional[bool] = None,
3040
disabled: Optional[bool] = None,
3141
data: Any = None,
@@ -52,6 +62,15 @@ def __init__(
5262
bottom=bottom,
5363
expand=expand,
5464
opacity=opacity,
65+
rotate=rotate,
66+
scale=scale,
67+
offset=offset,
68+
animate_opacity=animate_opacity,
69+
animate_size=animate_size,
70+
animate_position=animate_position,
71+
animate_rotation=animate_rotation,
72+
animate_scale=animate_scale,
73+
animate_offset=animate_offset,
5574
visible=visible,
5675
disabled=disabled,
5776
data=data,

sdk/python/flet/flet.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,11 +140,10 @@ def exit_gracefully(signum, frame):
140140
if view == WEB_BROWSER and url_prefix == None:
141141
open_in_browser(conn.page_url)
142142
try:
143-
if is_windows():
144-
input()
145-
else:
146-
terminate.wait()
147-
except (Exception) as e:
143+
while True:
144+
if terminate.wait(1):
145+
break
146+
except KeyboardInterrupt:
148147
pass
149148

150149
conn.close()

sdk/python/flet/icon.py

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,28 @@
22

33
from beartype import beartype
44

5-
from flet.control import Control, OptionalNumber
5+
from flet.constrained_control import ConstrainedControl
6+
from flet.control import OptionalNumber
67
from flet.ref import Ref
8+
from flet.types import AnimationValue, OffsetValue, RotateValue, ScaleValue
79

810

9-
class Icon(Control):
11+
class Icon(ConstrainedControl):
1012
def __init__(
1113
self,
1214
name: Optional[str] = None,
1315
ref: Optional[Ref] = None,
1416
expand: Union[None, bool, int] = None,
1517
opacity: OptionalNumber = None,
18+
rotate: RotateValue = None,
19+
scale: ScaleValue = None,
20+
offset: OffsetValue = None,
21+
animate_opacity: AnimationValue = None,
22+
animate_size: AnimationValue = None,
23+
animate_position: AnimationValue = None,
24+
animate_rotation: AnimationValue = None,
25+
animate_scale: AnimationValue = None,
26+
animate_offset: AnimationValue = None,
1627
tooltip: Optional[str] = None,
1728
visible: Optional[bool] = None,
1829
disabled: Optional[bool] = None,
@@ -24,11 +35,20 @@ def __init__(
2435
size: OptionalNumber = None,
2536
):
2637

27-
Control.__init__(
38+
ConstrainedControl.__init__(
2839
self,
2940
ref=ref,
3041
expand=expand,
3142
opacity=opacity,
43+
rotate=rotate,
44+
scale=scale,
45+
offset=offset,
46+
animate_opacity=animate_opacity,
47+
animate_size=animate_size,
48+
animate_position=animate_position,
49+
animate_rotation=animate_rotation,
50+
animate_scale=animate_scale,
51+
animate_offset=animate_offset,
3252
tooltip=tooltip,
3353
visible=visible,
3454
disabled=disabled,

sdk/python/flet/list_tile.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
class ListTile(ConstrainedControl):
1919
def __init__(
2020
self,
21-
text: Optional[str] = None,
2221
ref: Optional[Ref] = None,
2322
width: OptionalNumber = None,
2423
height: OptionalNumber = None,

sdk/python/flet/reconnecting_websocket.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ def __init__(self, url) -> None:
2424
if is_localhost_url(url)
2525
else _REMOTE_CONNECT_TIMEOUT_SEC
2626
)
27+
# disable websocket logging completely
28+
# https://github.com/websocket-client/websocket-client/blob/master/websocket/_logging.py#L22-L51
29+
ws_logger = logging.getLogger("websocket")
30+
ws_logger.setLevel(logging.FATAL)
2731

2832
@property
2933
def on_connect(self, handler):

0 commit comments

Comments
 (0)