Skip to content

Commit bc7dfd1

Browse files
committed
Dispose controls only on session closed event
Fix #1267 Fix #1272 Fix #1274 Fix #1279 Fix #1280
1 parent 9b353e9 commit bc7dfd1

File tree

1 file changed

+0
-4
lines changed
  • sdk/python/packages/flet-core/src/flet_core

1 file changed

+0
-4
lines changed

sdk/python/packages/flet-core/src/flet_core/page.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -334,7 +334,6 @@ def _clean(self, control: Control):
334334
self._send_command("clean", [control.uid])
335335
for c in removed_controls:
336336
c.will_unmount()
337-
c._dispose()
338337

339338
async def _clean_async(self, control: Control):
340339
async with self.__async_lock:
@@ -348,7 +347,6 @@ async def _clean_async(self, control: Control):
348347
await self._send_command_async("clean", [control.uid])
349348
for c in removed_controls:
350349
await c.will_unmount_async()
351-
c._dispose()
352350

353351
def _close(self):
354352
removed_controls = self._remove_control_recursively(self.index, self)
@@ -428,14 +426,12 @@ def __update_control_ids(self, added_controls, results):
428426
def __handle_mount_unmount(self, added_controls, removed_controls):
429427
for ctrl in removed_controls:
430428
ctrl.will_unmount()
431-
ctrl._dispose()
432429
for ctrl in added_controls:
433430
ctrl.did_mount()
434431

435432
async def __handle_mount_unmount_async(self, added_controls, removed_controls):
436433
for ctrl in removed_controls:
437434
await ctrl.will_unmount_async()
438-
ctrl._dispose()
439435
for ctrl in added_controls:
440436
await ctrl.did_mount_async()
441437

0 commit comments

Comments
 (0)