Skip to content

Commit ca99a26

Browse files
committed
Fixed infinite recursion in _remove_control_recursively()
Fix #1263
1 parent f306211 commit ca99a26

File tree

1 file changed

+7
-6
lines changed
  • sdk/python/packages/flet-core/src/flet_core

1 file changed

+7
-6
lines changed

sdk/python/packages/flet-core/src/flet_core/control.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -383,14 +383,15 @@ def build_update_commands(
383383
def _remove_control_recursively(self, index, control):
384384
removed_controls = []
385385

386-
for child in control._previous_children:
387-
removed_controls.extend(self._remove_control_recursively(index, child))
388-
389-
for child in control._get_children():
390-
removed_controls.extend(self._remove_control_recursively(index, child))
391-
392386
if control.__uid in index:
393387
del index[control.__uid]
388+
389+
for child in control._get_children():
390+
removed_controls.extend(self._remove_control_recursively(index, child))
391+
392+
for child in control._previous_children:
393+
removed_controls.extend(self._remove_control_recursively(index, child))
394+
394395
removed_controls.append(control)
395396

396397
return removed_controls

0 commit comments

Comments
 (0)