Commit f37c1f4
authored
Fix: View pop with confirmation (#5859)
* Improve view pop confirmation and update routing example
Enhanced pop confirmation logic in ViewControl by introducing _allowPop flag and handling dialogs listener removal. Updated Python routing example to use ft.run(main) and added a new pop_view_confirm.py example demonstrating custom pop confirmation dialogs.
* Refactor routing_navigation examples and add integration tests
Refactored Python routing_navigation example apps to use 'if __name__ == "__main__"' for entry points and unified Flet imports. Updated GitHub Actions workflows to use kuhnroyal/flutter-fvm-config-action/setup@v3 for Flutter setup and improved test matrix. Added integration tests for routing_navigation examples to verify navigation and view logic.
* Add bounds check to Pagelet and new integration tests
Introduces a bounds check in Pagelet to display an error when height is unbounded and not explicitly set. Adds new integration tests and golden images for Pagelet sizing scenarios, including explicitly sized and auto-sized cases.
Close #5562
* Refactor imports for consistency and clarity
Reorganized and standardized import statements across multiple files, replacing relative and package imports with a consistent style. This improves code readability, maintainability, and reduces potential import conflicts.
* Add drawer navigation example and tests
Introduces a new drawer navigation example app and corresponding integration test. Refactors BasePage to use top/root view for drawer and related properties/methods, improving multi-view navigation support.
* Update test scope and remove golden image
Changed the pytest mark for test_cupertino_adaptive to use function scope instead of module scope. Deleted the macOS golden image for pagelet basic, possibly due to test update or asset cleanup.
* Update macOS pagelet basic golden image
Replaces the basic.png golden image for macOS pagelet integration tests to reflect updated UI output.
* Remove unused logging and update test icon buttons
Removed unused logging setup from drawer_navigation.py. Updated test_pagelet.py to remove explicit icon_color assignments for IconButton controls in integration tests. Updated golden images to reflect these changes.1 parent 77a1958 commit f37c1f4
File tree
49 files changed
+749
-171
lines changed- .github/workflows
- packages/flet/lib/src
- controls
- extensions
- services
- utils
- sdk/python
- packages/flet
- integration_tests
- controls/core
- golden/macos/pagelet
- examples
- apps
- core/golden/macos/pagelet
- src/flet/controls
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
49 files changed
+749
-171
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
235 | 235 | | |
236 | 236 | | |
237 | 237 | | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | 238 | | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
251 | | - | |
252 | | - | |
253 | | - | |
254 | | - | |
255 | | - | |
| 239 | + | |
256 | 240 | | |
257 | | - | |
258 | | - | |
| 241 | + | |
| 242 | + | |
259 | 243 | | |
260 | 244 | | |
261 | 245 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
40 | 51 | | |
41 | 52 | | |
42 | 53 | | |
| |||
45 | 56 | | |
46 | 57 | | |
47 | 58 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 59 | | |
55 | | - | |
56 | | - | |
| 60 | + | |
57 | 61 | | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
| 62 | + | |
| 63 | + | |
69 | 64 | | |
70 | 65 | | |
71 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
| 7 | + | |
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
4 | 3 | | |
5 | 4 | | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
4 | 12 | | |
5 | 13 | | |
6 | 14 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
4 | 14 | | |
5 | 15 | | |
6 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | 5 | | |
| 6 | + | |
13 | 7 | | |
14 | 8 | | |
| 9 | + | |
15 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
16 | 14 | | |
| 15 | + | |
17 | 16 | | |
18 | 17 | | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
4 | 10 | | |
5 | 11 | | |
6 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | 1 | | |
3 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
4 | 20 | | |
5 | 21 | | |
6 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | 4 | | |
6 | 5 | | |
7 | 6 | | |
8 | 7 | | |
9 | 8 | | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
0 commit comments