v1: Controls integration tests - part I #5546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a new workflow to run integration tests on macOS 14 using CocoaPods, uv, and Flutter. The workflow installs dependencies, runs Python integration tests, and uploads failure screenshots as artifacts.
Replaces manual Flutter installation with subosito/flutter-action, sets FLUTTER_VERSION to 3.32.8, and simplifies the workflow. This improves maintainability and ensures consistent Flutter setup in CI.
Implemented the ability to take full-page screenshots in the Flutter page control and exposed it via the Python BasePage API. Updated the dropdown integration test to use the new screenshot feature and replaced golden images accordingly. Also clarified the integration test README for golden image generation.
…et-dev/flet into v1-controls-integration-tests
Also fixed content type
Introduces integration tests for canvas drawing features including color fill, points (as points, lines, polygon), and shadow rendering. Adds corresponding golden images for macOS to validate visual output.
…et-dev/flet into v1-controls-integration-tests
Temporarily disables the test_draw_shadow test in test_canvas.py using pytest.mark.skip, likely due to instability or pending fixes.
…et-dev/flet into v1-controls-integration-tests
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Deploying flet-docs with
|
| Latest commit: |
54e6305
|
| Status: | ⚡️ Build in progress... |
ndonkoHenri
reviewed
Aug 13, 2025
Comment on lines
+101
to
+121
| [ | ||
| fc.Shadow( | ||
| path=[ | ||
| fc.Path.SubPath( | ||
| x=0, | ||
| y=0, | ||
| elements=[ | ||
| fc.Path.MoveTo(x=10, y=10), | ||
| fc.Path.LineTo(x=40, y=10), | ||
| fc.Path.LineTo(x=40, y=40), | ||
| fc.Path.LineTo(x=10, y=40), | ||
| fc.Path.LineTo(x=10, y=10), | ||
| ], | ||
| ), | ||
| ], | ||
| color=ft.Colors.PINK, | ||
| elevation=1, | ||
| ) | ||
| ], | ||
| width=50, | ||
| height=50, |
Contributor
There was a problem hiding this comment.
following our discussion on "nesting hell", i will suggest we move width and height to the top. same for similar tests in this file.
Introduces a longPress method to the Tester interface and its implementations in Dart and Python, enabling long press interactions in automated tests. Updates the service layer to handle the new 'long_press' command.
…et-dev/flet into v1-controls-integration-tests
not done, menu doesn't open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Enable screenshot capturing in the Page control across Dart and Python SDKs and introduce a comprehensive suite of screenshot-based integration tests for various controls, while updating CI configurations to run macOS integration tests via GitHub Actions.
New Features:
Enhancements:
CI:
Documentation:
Tests: