-
Notifications
You must be signed in to change notification settings - Fork 600
v1(ci): use uv inline-scripting, prevent concurrent runs in macos-integration-tests GHA
#5558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine
Deploying flet-docs with
|
| Latest commit: |
f4b3caa
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a493c0f.flet-docs.pages.dev |
| Branch Preview URL: | https://v1-improve-gha.flet-docs.pages.dev |
| - 'sdk/python/packages/flet/integration_tests/**' | ||
|
|
||
| concurrency: | ||
| group: macos-integration-tests-${{ github.ref }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does github.ref mean here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
${{ github.ref }}is a GitHub Actions context variable that contains the full ref (reference) of the branch or tag that triggered the workflow. For example, for a branch it could berefs/heads/v1-improve-gha, and for a tag it could berefs/tags/v1.0.0. This is used to group workflow runs by branch or tag for concurrency control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so it's per branch. Understood.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-config-action/config` in macos-integration-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes CI scripts to use uv's inline scripting feature and adds path filtering and concurrency control to the macOS integration tests workflow.
- Migrates Python CI scripts to use uv inline scripting by adding script metadata headers and removing explicit
--withdependency flags - Configures GitHub Actions macOS integration tests to only run on relevant file changes and prevents concurrent workflow runs
- Makes minor documentation and code improvements including Flutter version updates and variable name clarifications
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ci/*.py | Added uv inline script metadata headers and removed redundant file mode arguments |
| .appveyor.yml | Removed explicit --with flags from uv run commands to use inline scripting |
| .github/workflows/macos-integration-tests.yml | Added path filters, concurrency control, and modernized Flutter setup |
| client/.fvmrc | Updated Flutter version from 3.32.4 to 3.32.8 |
| sdk/python/packages/flet/src/flet/testing/flet_test_app.py | Added newline character to print statement |
| sdk/python/packages/flet/src/flet/controls/theme.py | Simplified documentation and changed SystemOverlayStyle to optional |
| sdk/python/packages/flet/src/flet/controls/page.py | Improved window property documentation |
| sdk/python/packages/flet/src/flet/controls/material/datatable.py | Enhanced documentation formatting and decorator usage |
| packages/flet/lib/src/controls/window.dart | Replaced platform checks with utility function and improved variable naming |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Summary by Sourcery
Switch CI pipelines to use uv's inline scripting and add concurrency safeguards to the macOS integration workflow
Enhancements: