Skip to content

Conversation

@ndonkoHenri
Copy link
Contributor

@ndonkoHenri ndonkoHenri commented Aug 16, 2025

Summary by Sourcery

Switch CI pipelines to use uv's inline scripting and add concurrency safeguards to the macOS integration workflow

Enhancements:

  • Switch CI uv run/build commands to inline scripting by removing explicit --with plugin flags in AppVeyor scripts
  • Configure GitHub Actions macOS integration tests to only trigger on relevant path changes and cancel in-progress runs for the same branch
  • Simplify Python-based CI helper scripts by removing redundant file mode arguments when opening files

@ndonkoHenri ndonkoHenri requested a review from Copilot August 16, 2025 16:46

This comment was marked as outdated.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2025

Deploying flet-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: f4b3caa
Status: ✅  Deploy successful!
Preview URL: https://1a493c0f.flet-docs.pages.dev
Branch Preview URL: https://v1-improve-gha.flet-docs.pages.dev

View logs

- 'sdk/python/packages/flet/integration_tests/**'

concurrency:
group: macos-integration-tests-${{ github.ref }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does github.ref mean here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

${{ github.ref }} is a GitHub Actions context variable that contains the full ref (reference) of the branch or tag that triggered the workflow. For example, for a branch it could be refs/heads/v1-improve-gha, and for a tag it could be refs/tags/v1.0.0. This is used to group workflow runs by branch or tag for concurrency control.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so it's per branch. Understood.

Copy link
Contributor Author

@ndonkoHenri ndonkoHenri Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just from modifying the group name again to prevent duplicate runs when pushing a commit to a branch which has an opened PR.
image

Now in such cases, only the PR run will take the lead, and the branch run will be cancelled.

@ndonkoHenri ndonkoHenri requested a review from Copilot August 17, 2025 08:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes CI scripts to use uv's inline scripting feature and adds path filtering and concurrency control to the macOS integration tests workflow.

  • Migrates Python CI scripts to use uv inline scripting by adding script metadata headers and removing explicit --with dependency flags
  • Configures GitHub Actions macOS integration tests to only run on relevant file changes and prevents concurrent workflow runs
  • Makes minor documentation and code improvements including Flutter version updates and variable name clarifications

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
ci/*.py Added uv inline script metadata headers and removed redundant file mode arguments
.appveyor.yml Removed explicit --with flags from uv run commands to use inline scripting
.github/workflows/macos-integration-tests.yml Added path filters, concurrency control, and modernized Flutter setup
client/.fvmrc Updated Flutter version from 3.32.4 to 3.32.8
sdk/python/packages/flet/src/flet/testing/flet_test_app.py Added newline character to print statement
sdk/python/packages/flet/src/flet/controls/theme.py Simplified documentation and changed SystemOverlayStyle to optional
sdk/python/packages/flet/src/flet/controls/page.py Improved window property documentation
sdk/python/packages/flet/src/flet/controls/material/datatable.py Enhanced documentation formatting and decorator usage
packages/flet/lib/src/controls/window.dart Replaced platform checks with utility function and improved variable naming

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ndonkoHenri ndonkoHenri linked an issue Aug 17, 2025 that may be closed by this pull request
1 task
@FeodorFitsner FeodorFitsner merged commit 4ea9558 into main Aug 17, 2025
4 checks passed
@FeodorFitsner FeodorFitsner deleted the v1-improve-gha branch August 17, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting an empty page theme changes Android status bar

3 participants