Owen/control docs p8 #5887
Open
Owen/control docs p8 #5887
+369
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying flet-docs with
|
| Latest commit: |
198465f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c34ff6b.flet-docs.pages.dev |
| Branch Preview URL: | https://owen-control-docs-p8.flet-docs.pages.dev |
| ) | ||
| flet_app_function.assert_screenshot( | ||
| "image_for_docs", | ||
| await flet_app_function.page.take_screenshot(), |
Contributor
There was a problem hiding this comment.
pixel ration argument should be passed into page.take_screenshot() call, otherwise the test will be failing in CI environment with non-hi-res virtual display.
await flet_app_function.page.take_screenshot(
pixel_ratio=flet_app_function.screenshots_pixel_ratio
),Make sure this is fixed everywhere.
| flet_app_function.assert_screenshot( | ||
| "image_for_docs", | ||
| await flet_app_function.page.take_screenshot(), | ||
| ) |
Contributor
There was a problem hiding this comment.
and while you are there you may make this screenshot wider to remove horizontal scrollbar: https://github.com/flet-dev/flet/pull/5887/files#diff-e60ac2b820dd5525c3013f9ce6bbae7a779531b432745ba86a4308ab276ea6c1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add NavigationBar, MenuBar, MenuItemButton, and ListView example tests and images.