Skip to content

Commit 2ec7fec

Browse files
committed
Address comments
1 parent 1a0522d commit 2ec7fec

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

tests/simulation/translator/data/simulation_stopping_criterion.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@
218218
"value": 0.0,
219219
"units": "m"
220220
},
221-
"private_attribute_id": "wallBC1"
221+
"private_attribute_id": "wallBC"
222222
},
223223
{
224224
"type": "SlipWall",
@@ -255,11 +255,12 @@
255255
{
256256
"private_attribute_entity_type_name": "Surface",
257257
"name": "4",
258+
"private_attribute_id": "ef389961-e941-4a0a-a910-55c6d303f7e5",
258259
"private_attribute_sub_components": []
259260
}
260261
]
261262
},
262-
"private_attribute_id": "wallBC",
263+
"private_attribute_id": "209302bf-9eeb-449b-b7c4-a4e5c04a5b17",
263264
"name": "wing",
264265
"use_wall_function": false,
265266
"heat_spec": {
@@ -458,7 +459,7 @@
458459
"private_attribute_id": "33333",
459460
"name": "force_wallBC",
460461
"models": [
461-
"wallBC"
462+
"209302bf-9eeb-449b-b7c4-a4e5c04a5b17"
462463
],
463464
"moving_statistic": {
464465
"moving_window_size": 10,

tests/simulation/translator/test_solver_translator.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import json
22
import os
33
import unittest
4+
import uuid
45

56
import numpy as np
67
import pytest
@@ -472,7 +473,7 @@ def test_om6wing_with_stopping_criterion_and_moving_statistic(get_om6Wing_tutori
472473
monitor_field=mass_flow_rate,
473474
tolerance_window_size=3,
474475
)
475-
wallBC = Wall(name="wing", surfaces=[Surface(name="4")], private_attribute_id="wallBC")
476+
wallBC = Wall(name="wing", surfaces=[Surface(name="4", private_attribute_id=str(uuid.uuid4()))])
476477
force_output = ForceOutput(
477478
name="force_wallBC",
478479
models=[wallBC],

0 commit comments

Comments
 (0)