Added local and global options for preserve_thin_geometry (#1423)

* Added local and global options for preserve_thin_geometry

* Fix translation of surface meshing json

---------

Co-authored-by: Chaitanya Talnikar <chaitanya@flexcompute.com>

Author: savithru-flex

flow360/component/simulation/meshing_param/face_params.py

@@ -66,8 +66,15 @@ class GeometryRefinement(Flow360BaseModel):
     entities: EntityList[Surface] = pd.Field(alias="faces")
     # pylint: disable=no-member
 
-    geometry_accuracy: LengthType.Positive = pd.Field(
-        description="The smallest length scale that will be resolved accurately by the surface meshing process. "
+    geometry_accuracy: Optional[LengthType.Positive] = pd.Field(
+        None,
+        description="The smallest length scale that will be resolved accurately by the surface meshing process. ",
+    )
+
+    preserve_thin_geometry: Optional[bool] = pd.Field(
+        False,
+        description="Flag to specify whether thin geometry features with thickness roughly equal "
+        + "to geometry_accuracy should be resolved accurately during the surface meshing process.",
     )
 
     @pd.field_validator("entities", mode="after")

flow360/component/simulation/meshing_param/params.py

@@ -152,6 +152,13 @@ class MeshingDefaults(Flow360BaseModel):
         context=SURFACE_MESH,
     )
 
+    preserve_thin_geometry: Optional[bool] = pd.Field(
+        False,
+        description="Flag to specify whether thin geometry features with thickness roughly equal "
+        + "to geometry_accuracy should be resolved accurately during the surface meshing process."
+        + "This can be overridden with class: ~flow360.GeometryRefinement",
+    )
+
     @pd.field_validator("number_of_boundary_layers", mode="after")
     @classmethod
     def invalid_number_of_boundary_layers(cls, value):
@@ -182,11 +189,14 @@ def invalid_geometry_accuracy(cls, value):
         return value
 
     @pd.field_validator(
-        "surface_max_aspect_ratio", "surface_max_adaptation_iterations", mode="after"
+        "surface_max_aspect_ratio",
+        "surface_max_adaptation_iterations",
+        "preserve_thin_geometry",
+        mode="after",
     )
     @classmethod
     def invalid_geometry_ai_features(cls, value, info):
-        """Ensure surface max aspect ratio is not specified when GAI is not used"""
+        """Ensure GAI features are not specified when GAI is not used"""
         validation_info = get_validation_info()
 
         if validation_info is None:

flow360/component/simulation/translator/surface_meshing_translator.py

@@ -154,6 +154,7 @@ def _get_surface_refinements(refinement_list: list[dict]):
             "curvature_resolution_angle": None,
             "surface_edge_growth_rate": None,
             "geometry_accuracy": None,
+            "preserve_thin_geometry": None,
             "surface_max_aspect_ratio": None,
             "surface_max_adaptation_iterations": None,
         },

tests/ref/simulation/service_init_geometry.json

@@ -7,15 +7,16 @@
         "refinement_factor": 1.0,
         "gap_treatment_strength": 0.0,
         "defaults": {
-            "boundary_layer_growth_rate": 1.2,
-            "curvature_resolution_angle": {
-                "units": "degree",
-                "value": 12.0
-            },
             "surface_edge_growth_rate": 1.2,
+            "boundary_layer_growth_rate": 1.2,
             "planar_face_tolerance": 1e-06,
+            "surface_max_aspect_ratio": 10.0,
             "surface_max_adaptation_iterations": 50,
-            "surface_max_aspect_ratio": 10.0
+            "curvature_resolution_angle": {
+                "value": 12.0,
+                "units": "degree"
+            },
+            "preserve_thin_geometry": false
         },
         "refinements": [],
         "volume_zones": [
@@ -192,7 +193,6 @@
                     }
                 }
             },
-            "type": "Fluid",
             "initial_condition": {
                 "type_name": "NavierStokesInitialCondition",
                 "rho": "rho",
@@ -201,6 +201,7 @@
                 "w": "w",
                 "p": "p"
             },
+            "type": "Fluid",
             "navier_stokes_solver": {
                 "absolute_tolerance": 1e-10,
                 "relative_tolerance": 0.0,
@@ -268,13 +269,9 @@
             "convergence_limiting_factor": 0.25
         }
     },
+    "user_defined_fields": [],
     "outputs": [
         {
-            "frequency": -1,
-            "frequency_offset": 0,
-            "output_format": "paraview",
-            "name": "Surface output",
-            "write_single_file": false,
             "output_fields": {
                 "items": [
                     "Cp",
@@ -283,6 +280,10 @@
                     "CfVec"
                 ]
             },
+            "frequency": -1,
+            "frequency_offset": 0,
+            "output_format": "paraview",
+            "name": "Surface output",
             "entities": {
                 "stored_entities": [
                     {
@@ -293,10 +294,10 @@
                     }
                 ]
             },
+            "write_single_file": false,
             "output_type": "SurfaceOutput"
         }
     ],
-    "user_defined_fields": [],
     "private_attribute_asset_cache": {
         "project_length_unit": {
             "value": 1.0,

tests/ref/simulation/service_init_surface_mesh.json

@@ -10,12 +10,13 @@
             "surface_edge_growth_rate": 1.2,
             "boundary_layer_growth_rate": 1.2,
             "planar_face_tolerance": 1e-06,
-            "surface_max_adaptation_iterations": 50,
             "surface_max_aspect_ratio": 10.0,
+            "surface_max_adaptation_iterations": 50,
             "curvature_resolution_angle": {
                 "value": 12.0,
                 "units": "degree"
-            }
+            },
+            "preserve_thin_geometry": false
         },
         "refinements": [],
         "volume_zones": [
@@ -271,6 +272,14 @@
     "user_defined_fields": [],
     "outputs": [
         {
+            "output_fields": {
+                "items": [
+                    "Cp",
+                    "yPlus",
+                    "Cf",
+                    "CfVec"
+                ]
+            },
             "frequency": -1,
             "frequency_offset": 0,
             "output_format": "paraview",
@@ -286,14 +295,6 @@
                 ]
             },
             "write_single_file": false,
-            "output_fields": {
-                "items": [
-                    "Cp",
-                    "yPlus",
-                    "Cf",
-                    "CfVec"
-                ]
-            },
             "output_type": "SurfaceOutput"
         }
     ],

tests/simulation/params/test_unit_conversions.py

@@ -169,7 +169,7 @@ def test_operations_on_units():
     assert str(replaced.units) == "dimensionless"
 
     replaced = params.operating_condition.velocity_magnitude**5 - (1 / 50 * (fl.u.km / fl.u.s) ** 5)
-    assertions.assertAlmostEqual(replaced.value, 502472105493.3395)
+    assertions.assertAlmostEqual(replaced.value, 502472105493.3395, 3)
     assert str(replaced.units) == "inch**5*m**5/(cm**5*s**5)"
 
     replaced = (

tests/simulation/translator/ref/surface_meshing/gai_surface_mesher.json

@@ -14,6 +14,7 @@
                 "value": 0.05,
                 "units": "flow360_length_unit"
             },
+            "preserve_thin_geometry": false,
             "surface_max_aspect_ratio": 0.01,
             "surface_max_adaptation_iterations": 19
         },
@@ -177,6 +178,7 @@
                         }
                     ]
                 },
+                "preserve_thin_geometry": false,
                 "geometry_accuracy": {
                     "value": 0.05,
                     "units": "flow360_length_unit"
@@ -629,4 +631,4 @@
             ]
         }
     }
-}
+}