Skip to content

Commit dad5fd7

Browse files
bug(): Removed duplicate pressure output when pressure is specified (#1309)
1 parent 5e8892d commit dad5fd7

File tree

3 files changed

+5
-18
lines changed

3 files changed

+5
-18
lines changed

flow360/component/simulation/outputs/output_fields.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,7 @@ def get_unit_for_field(field_name: str):
292292
"velocity_x": "velocity_x = primitiveVars[1] * velocityScale;",
293293
"velocity_y": "velocity_y = primitiveVars[2] * velocityScale;",
294294
"velocity_z": "velocity_z = primitiveVars[3] * velocityScale;",
295-
"pressure": "double gamma = 1.4;pressure = (usingLiquidAsMaterial) ? "
295+
"pressure_": "double gamma = 1.4;pressure_ = (usingLiquidAsMaterial) ? "
296296
+ "(primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];",
297297
"wall_shear_stress_magnitude": "wall_shear_stress_magnitude = "
298298
+ "magnitude(wallShearStress) * (velocityScale * velocityScale);",

tests/simulation/outputs/test_output_fields.py

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -107,22 +107,14 @@ def test_generate_field_udf_velocity_magnitude(simulation_params):
107107
assert result == expected
108108

109109

110-
def test_generate_field_pressure_no_unit(simulation_params):
111-
"""Test generating UDF expression for pressure fields."""
112-
113-
result = generate_predefined_udf("pressure", simulation_params)
114-
expected = "double gamma = 1.4;pressure = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];"
115-
assert result == expected
116-
117-
118110
def test_generate_field_udf_pressure(simulation_params):
119111
"""Test generating UDF expression for pressure fields."""
120112

121113
result = generate_predefined_udf("pressure_pa", simulation_params)
122114
expected = (
123-
"double pressure;double gamma = 1.4;"
124-
"pressure = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];"
125-
"pressure_pa = pressure * 141855.01272652458;"
115+
"double pressure_;double gamma = 1.4;"
116+
"pressure_ = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];"
117+
"pressure_pa = pressure_ * 141855.01272652458;"
126118
)
127119
assert result == expected
128120

tests/simulation/translator/test_output_translation.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1344,14 +1344,9 @@ def test_dimensioned_output_fields_translation(vel_in_km_per_hr):
13441344
ref = {
13451345
"userDefinedFields": [
13461346
{"name": "my_field", "expression": "1+1", "from_user_variables": False},
1347-
{
1348-
"name": "pressure",
1349-
"expression": "double gamma = 1.4;pressure = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];",
1350-
"from_user_variables": False,
1351-
},
13521347
{
13531348
"name": "pressure_pa",
1354-
"expression": "double pressure;double gamma = 1.4;pressure = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];pressure_pa = pressure * 2500000.0;",
1349+
"expression": "double pressure_;double gamma = 1.4;pressure_ = (usingLiquidAsMaterial) ? (primitiveVars[4] - 1.0 / gamma) * (velocityScale * velocityScale) : primitiveVars[4];pressure_pa = pressure_ * 2500000.0;",
13551350
"from_user_variables": False,
13561351
},
13571352
{

0 commit comments

Comments
 (0)