[Hotfix Main]: [SNAPPY] Adds an option to ignore region edges in edge refinement (#1814)

github-actions[bot] · piotrkluba · web-flow · commit e1dd9ffe6957 · 2026-02-17T10:25:18.000Z
Co-authored-by: piotrkluba &lt;piotr.kluba@flexcompute.com&gt;
diff --git a/flow360/component/simulation/meshing_param/snappy/snappy_mesh_refinements.py b/flow360/component/simulation/meshing_param/snappy/snappy_mesh_refinements.py
@@ -113,6 +113,10 @@ class SurfaceEdgeRefinement(Flow360BaseModel):
     retain_on_smoothing: bool = pd.Field(
         True, description="Maintain the edge when smoothing is applied."
     )
+    geometric_test_only: bool = pd.Field(
+        False,
+        description="If enabled, only geometric tests are performed on the edge (region edge will be ignored).",
+    )
 
     @pd.model_validator(mode="after")
     def _check_spacing_format(self) -> Self:
diff --git a/flow360/component/simulation/translator/surface_meshing_translator.py b/flow360/component/simulation/translator/surface_meshing_translator.py
@@ -165,6 +165,7 @@ def apply_SnappySurfaceEdgeRefinement(
         edges["minLen"] = refinement.min_len.value.item()
     if refinement.retain_on_smoothing is not None:
         edges["retainOnSmoothing"] = refinement.retain_on_smoothing
+    edges["geometricTestOnly"] = refinement.geometric_test_only
     if refinement.spacing is None:
         edges["edgeSpacing"] = defaults.min_spacing.value.item()
     elif isinstance(refinement.spacing, unyt_array) and isinstance(
diff --git a/tests/simulation/translator/ref/surface_meshing/snappy_basic_refinements.json b/tests/simulation/translator/ref/surface_meshing/snappy_basic_refinements.json
@@ -20,7 +20,8 @@
                             "edgeSpacing": [[5, 4]],
                             "minElem": 3,
                             "includedAngle": 120,
-                            "retainOnSmoothing": true
+                            "retainOnSmoothing": true,
+                            "geometricTestOnly": false
                         }
                     },
                     {
@@ -38,7 +39,8 @@
                             ],
                             "minLen": 6,
                             "includedAngle": 150,
-                            "retainOnSmoothing": false
+                            "retainOnSmoothing": false,
+                            "geometricTestOnly": false
                         }
                     }
                 ]
@@ -54,7 +56,8 @@
                         "edgeSpacing": 4,
                         "minElem": 3,
                         "includedAngle": 120,
-                        "retainOnSmoothing": true
+                        "retainOnSmoothing": true,
+                        "geometricTestOnly": true
                     },
                 "regions": [
                     {
@@ -80,7 +83,8 @@
                             ],
                             "minLen": 6,
                             "includedAngle": 150,
-                            "retainOnSmoothing": false
+                            "retainOnSmoothing": false,
+                            "geometricTestOnly": false
                         }
                     },
                     {
@@ -122,7 +126,8 @@
                     ],
                     "minLen": 6,
                     "includedAngle": 150,
-                    "retainOnSmoothing": false
+                    "retainOnSmoothing": false,
+                    "geometricTestOnly": false
                 },
                 "regions": [
                     {
diff --git a/tests/simulation/translator/ref/surface_meshing/snappy_no_regions.json b/tests/simulation/translator/ref/surface_meshing/snappy_no_regions.json
@@ -31,7 +31,8 @@
                     "edgeSpacing": 4,
                     "minElem": 3,
                     "includedAngle": 120,
-                    "retainOnSmoothing": true
+                    "retainOnSmoothing": true,
+                    "geometricTestOnly": false
                 },
                 "regions": []
             }
diff --git a/tests/simulation/translator/ref/surface_meshing/snappy_refinements_multiple_regions.json b/tests/simulation/translator/ref/surface_meshing/snappy_refinements_multiple_regions.json
@@ -19,7 +19,8 @@
                             "edgeSpacing": 4,
                             "minElem": 3,
                             "includedAngle": 120,
-                            "retainOnSmoothing": false
+                            "retainOnSmoothing": false,
+                            "geometricTestOnly": true
                         }
                     },
                     {
@@ -32,7 +33,8 @@
                             "edgeSpacing": 4,
                             "minElem": 3,
                             "includedAngle": 120,
-                            "retainOnSmoothing": false
+                            "retainOnSmoothing": false,
+                            "geometricTestOnly": true
                         }
                     }
                 ]
diff --git a/tests/simulation/translator/test_surface_meshing_translator.py b/tests/simulation/translator/test_surface_meshing_translator.py
@@ -638,6 +638,7 @@ def snappy_basic_refinements():
                     min_elem=3,
                     included_angle=120 * u.deg,
                     entities=test_geometry.snappy_bodies["body1"],
+                    geometric_test_only=True,
                 ),
                 snappy.SurfaceEdgeRefinement(
                     spacing=[4 * u.mm],
@@ -796,6 +797,7 @@ def snappy_refinements_multiple_regions():
                     included_angle=120 * u.deg,
                     entities=[test_geometry["body0::patch0"], test_geometry["body0::patch1"]],
                     retain_on_smoothing=False,
+                    geometric_test_only=True,
                 ),
             ],
             smooth_controls=snappy.SmoothControls(),

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,8 @@`
`20`	`20`	`"edgeSpacing": [[5, 4]],`
`21`	`21`	`"minElem": 3,`
`22`	`22`	`"includedAngle": 120,`
`23`		`- "retainOnSmoothing": true`
	`23`	`+ "retainOnSmoothing": true,`
	`24`	`+ "geometricTestOnly": false`
`24`	`25`	`}`
`25`	`26`	`},`
`26`	`27`	`{`
`@@ -38,7 +39,8 @@`
`38`	`39`	`],`
`39`	`40`	`"minLen": 6,`
`40`	`41`	`"includedAngle": 150,`
`41`		`- "retainOnSmoothing": false`
	`42`	`+ "retainOnSmoothing": false,`
	`43`	`+ "geometricTestOnly": false`
`42`	`44`	`}`
`43`	`45`	`}`
`44`	`46`	`]`
`@@ -54,7 +56,8 @@`
`54`	`56`	`"edgeSpacing": 4,`
`55`	`57`	`"minElem": 3,`
`56`	`58`	`"includedAngle": 120,`
`57`		`- "retainOnSmoothing": true`
	`59`	`+ "retainOnSmoothing": true,`
	`60`	`+ "geometricTestOnly": true`
`58`	`61`	`},`
`59`	`62`	`"regions": [`
`60`	`63`	`{`
`@@ -80,7 +83,8 @@`
`80`	`83`	`],`
`81`	`84`	`"minLen": 6,`
`82`	`85`	`"includedAngle": 150,`
`83`		`- "retainOnSmoothing": false`
	`86`	`+ "retainOnSmoothing": false,`
	`87`	`+ "geometricTestOnly": false`
`84`	`88`	`}`
`85`	`89`	`},`
`86`	`90`	`{`
`@@ -122,7 +126,8 @@`
`122`	`126`	`],`
`123`	`127`	`"minLen": 6,`
`124`	`128`	`"includedAngle": 150,`
`125`		`- "retainOnSmoothing": false`
	`129`	`+ "retainOnSmoothing": false,`
	`130`	`+ "geometricTestOnly": false`
`126`	`131`	`},`
`127`	`132`	`"regions": [`
`128`	`133`	`{`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,8 @@`
`19`	`19`	`"edgeSpacing": 4,`
`20`	`20`	`"minElem": 3,`
`21`	`21`	`"includedAngle": 120,`
`22`		`- "retainOnSmoothing": false`
	`22`	`+ "retainOnSmoothing": false,`
	`23`	`+ "geometricTestOnly": true`
`23`	`24`	`}`
`24`	`25`	`},`
`25`	`26`	`{`
`@@ -32,7 +33,8 @@`
`32`	`33`	`"edgeSpacing": 4,`
`33`	`34`	`"minElem": 3,`
`34`	`35`	`"includedAngle": 120,`
`35`		`- "retainOnSmoothing": false`
	`36`	`+ "retainOnSmoothing": false,`
	`37`	`+ "geometricTestOnly": true`
`36`	`38`	`}`
`37`	`39`	`}`
`38`	`40`	`]`