Skip to content

Commit fb9e432

Browse files
[FXC-2300] Improved error message when using legacy output field names (#1366)
1 parent e025e34 commit fb9e432

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

flow360/component/simulation/user_code/core/types.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -529,7 +529,9 @@ def check_value_is_not_legacy_variable(cls, v):
529529

530530
all_field_names = set(AllFieldNames.__args__)
531531
if v in all_field_names:
532-
raise ValueError(f"'{v}' is a reserved (legacy) output field name.")
532+
raise ValueError(
533+
f"'{v}' is a reserved (legacy) output field name. It cannot be used in expressions."
534+
)
533535
return v
534536

535537
@pd.field_validator("name", mode="after")

tests/simulation/test_expressions.py

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -874,9 +874,18 @@ def test_unique_dimensions():
874874
("template", "'template' is a reserved keyword."),
875875
("temperature", "'temperature' is a reserved solver side variable name."),
876876
("area", "'area' is a reserved solver side variable name."),
877-
("velocity", "'velocity' is a reserved (legacy) output field name."),
878-
("mut", "'mut' is a reserved (legacy) output field name."),
879-
("pressure", "'pressure' is a reserved (legacy) output field name."),
877+
(
878+
"velocity",
879+
"'velocity' is a reserved (legacy) output field name. It cannot be used in expressions.",
880+
),
881+
(
882+
"mut",
883+
"'mut' is a reserved (legacy) output field name. It cannot be used in expressions.",
884+
),
885+
(
886+
"pressure",
887+
"'pressure' is a reserved (legacy) output field name. It cannot be used in expressions.",
888+
),
880889
],
881890
)
882891
def test_invalid_names_raise(bad_name, expected_msg):

0 commit comments

Comments
 (0)