Skip to content

Raise on error by default #1351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benflexcompute merged 8 commits into from
Aug 11, 2025
Merged

Raise on error by default #1351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
105b6ea
Added Python version for user agent
benflexcompute Aug 11, 2025
74cf476
Fix lint
benflexcompute Aug 11, 2025
fd0d648
Raise on error by default
benflexcompute Aug 11, 2025
73bffed
Changed the default to raise on error submission to avoid user confusion
benflexcompute Aug 11, 2025
7aee6ed
Better error message
benflexcompute Aug 11, 2025
efe88f8
Fix conflict
benflexcompute Aug 11, 2025
c5dd8ec
Merge branch 'BenY/AddPythonVersion' into BenY/RaiseOnErrorByDefault
benflexcompute Aug 11, 2025
74a718e
Merge branch 'release-candidate/25.6' into BenY/RaiseOnErrorByDefault
benflexcompute Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions flow360/component/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1363,7 +1363,7 @@ def _run(
use_geometry_AI : bool, optional
Whether to use the Geometry AI (default is False).
raise_on_error: bool, optional
Option to raise if submission error occurs (default is False)
Option to raise if submission error occurs
tags: List[str], optional
A list of tags to add to the target asset.
draft_only: bool, optional
Expand Down Expand Up @@ -1408,10 +1408,10 @@ def _run(

if errors is not None:
log.error(
f"Validation error found in the simulation params: {formatting_validation_errors(errors=errors)}"
f"Validation error found during local validation: {formatting_validation_errors(errors=errors)}"
)
if raise_on_error:
raise ValueError("Submission terminated due to validation error.")
raise ValueError("Submission terminated due to local validation error.")
return None

source_item_type = self.metadata.root_item_type.value if fork_from is None else "Case"
Expand Down Expand Up @@ -1496,7 +1496,7 @@ def generate_surface_mesh(
solver_version: str = None,
use_beta_mesher: bool = None,
use_geometry_AI: bool = False, # pylint: disable=invalid-name
raise_on_error: bool = False,
raise_on_error: bool = True,
tags: List[str] = None,
draft_only: bool = False,
**kwargs,
Expand All @@ -1519,7 +1519,7 @@ def generate_surface_mesh(
use_geometry_AI : bool, optional
Whether to use the Geometry AI (default is False).
raise_on_error: bool, optional
Option to raise if submission error occurs (default is False)
Option to raise if submission error occurs (default is True)
tags: List[str], optional
A list of tags to add to the generated surface mesh.
draft_only: bool, optional
Expand Down Expand Up @@ -1566,7 +1566,7 @@ def generate_volume_mesh(
solver_version: str = None,
use_beta_mesher: bool = None,
use_geometry_AI: bool = False, # pylint: disable=invalid-name
raise_on_error: bool = False,
raise_on_error: bool = True,
tags: List[str] = None,
draft_only: bool = False,
**kwargs,
Expand All @@ -1589,7 +1589,7 @@ def generate_volume_mesh(
use_geometry_AI : bool, optional
Whether to use the Geometry AI (default is False).
raise_on_error: bool, optional
Option to raise if submission error occurs (default is False)
Option to raise if submission error occurs (default is True)
tags: List[str], optional
A list of tags to add to the generated volume mesh.
draft_only: bool, optional
Expand Down Expand Up @@ -1645,7 +1645,7 @@ def run_case(
solver_version: str = None,
use_beta_mesher: bool = None,
use_geometry_AI: bool = False, # pylint: disable=invalid-name
raise_on_error: bool = False,
raise_on_error: bool = True,
tags: List[str] = None,
draft_only: bool = False,
**kwargs,
Expand All @@ -1672,7 +1672,7 @@ def run_case(
use_geometry_AI : bool, optional
Whether to use the Geometry AI (default is False).
raise_on_error: bool, optional
Option to raise if submission error occurs (default is False)
Option to raise if submission error occurs (default is True)
tags: List[str], optional
A list of tags to add to the case.
draft_only: bool, optional
Expand Down
2 changes: 1 addition & 1 deletion flow360/component/simulation/web/draft.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ def run_up_to_target_asset(
return destination_id
except Flow360WebError as err:
# Error found when translating/running the simulation
log.error(">>Submission failed.<<")
log.error(">>Submission to cloud failed.<<")
try:
detailed_error = json.loads(err.auxiliary_json["detail"])["detail"]
log.error(
Expand Down
Loading