Backwards compatibility methods?

Author: daquinteroflex

tidy3d/plugins/smatrix/component_modelers/terminal.py

@@ -2,6 +2,7 @@
 
 from __future__ import annotations
 
+import os
 from typing import Optional, Union
 
 import numpy as np
@@ -430,27 +431,27 @@ def compute_port_VI(
 
         return compute_port_VI(port_out=port_out, sim_data=sim_data)
 
-    # @cached_property
-    # def _terminal_modeler_path(self) -> str:
-    #     """Where we store the  for this :class:`TerminalComponentModeler` instance after the run."""
-    #     return os.path.join(self.path_dir, "tcp_" + str(hash(self)) + ".hdf5")
-    #
-    # def _upload_terminal_modeler(self):
-    #     # TODO properly refactor, plugins data types should not have web methods.
-    #     from tidy3d.web.api.container import Job
-    #
-    #     # first try loading the terminal_component_modeler from file, if it exists
-    #     terminal_modeler_path = self._terminal_modeler_path
-    #
-    #     if os.path.exists(terminal_modeler_path):
-    #         return Job.from_file(fname=terminal_modeler_path)
-    #
-    #     return Job(
-    #         simulation=self,
-    #         task_name=self.name,
-    #         folder_name=self.folder_name,
-    #         callback_url=self.callback_url,
-    #         verbose=self.verbose,
-    #         solver_version=self.solver_version,
-    #         simulation_type="microwave",
-    #     )
+    @cached_property
+    def _terminal_modeler_path(self) -> str:
+        """Where we store the  for this :class:`TerminalComponentModeler` instance after the run."""
+        return os.path.join(self.path_dir, "tcp_" + str(hash(self)) + ".hdf5")
+
+    def _upload_terminal_modeler(self):
+        # TODO properly refactor, plugins data types should not have web methods.
+        from tidy3d.web.api.container import Job
+
+        # first try loading the terminal_component_modeler from file, if it exists
+        terminal_modeler_path = self._terminal_modeler_path
+
+        if os.path.exists(terminal_modeler_path):
+            return Job.from_file(fname=terminal_modeler_path)
+
+        return Job(
+            simulation=self,
+            task_name=self.name,
+            folder_name=self.folder_name,
+            callback_url=self.callback_url,
+            verbose=self.verbose,
+            solver_version=self.solver_version,
+            simulation_type="microwave",
+        )