Skip to content

Commit 19229c8

Browse files
committed
tighter tolerance used for mode solvers
1 parent 646b4b4 commit 19229c8

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1010
### Changed
1111
- By default, batch downloads will skip files that already exist locally. To force re-downloading and replace existing files, pass the `replace_existing=True` argument to `Batch.load()`, `Batch.download()`, or `BatchData.load()`.
1212
- The `BatchData.load_sim_data()` function now overwrites any previously downloaded simulation files (instead of skipping them).
13+
- Tighter `TOL_EIGS` used for mode solver, since `scipy` sometimes failed to find modes.
1314

1415
### Fixed
1516
- Giving opposite boundaries different names no longer causes a symmetry validator failure.

tidy3d/components/mode/solver.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
# Consider vec to be complex if norm(vec.imag)/norm(vec) > TOL_COMPLEX
1818
TOL_COMPLEX = 1e-10
1919
# Tolerance for eigs
20-
TOL_EIGS = fp_eps
20+
TOL_EIGS = fp_eps / 10
2121
# Tolerance for deciding on the matrix to be diagonal or tensorial
2222
TOL_TENSORIAL = 1e-6
2323
# shift target neff by this value, both rel and abs, whichever results in larger shift

0 commit comments

Comments
 (0)