greptile comments

Author: dbochkov-flexcompute

tests/test_components/test_absorbers.py

@@ -117,7 +117,7 @@ def test_port_absorbers_simulations():
             ],
         )
 
-    # need to define frequence for ModeABCBoundary
+    # need to define frequency for ModeABCBoundary
     # manually
     _ = td.Simulation(
         center=[0, 0, 0],
@@ -352,7 +352,7 @@ def test_abc_boundaries_simulations():
         run_time=1e-20,
         boundary_spec=td.BoundarySpec.all_sides(td.ABCBoundary(permittivity=2)),
     )
-    # not ok if ABC boudary is crossed
+    # not ok if ABC boundary is crossed
     with pytest.raises(pydantic.ValidationError):
         _ = td.Simulation(
             center=[0, 0, 0],
@@ -416,7 +416,7 @@ def test_abc_boundaries_simulations():
             boundary_spec=td.BoundarySpec.all_sides(td.ABCBoundary()),
         )
 
-    # need to define frequence for ModeABCBoundary
+    # need to define frequency for ModeABCBoundary
     # manually
     _ = td.Simulation(
         center=[0, 0, 0],

tidy3d/components/boundary.py

@@ -107,7 +107,7 @@ class ABCBoundary(AbstractABCBoundary):
     conductivity: Optional[pd.NonNegativeFloat] = pd.Field(
         None,
         title="Effective Conductivity",
-        description="Effective conductivity for determining propagation constant."
+        description="Effective conductivity for determining propagation constant. "
         "If ``None``, this value will be automatically inferred from the medium at "
         "the domain boundary and the central frequency of the source.",
     )
@@ -197,7 +197,7 @@ def from_source(cls, source: ModeSource) -> ModeABCBoundary:
     def from_monitor(
         cls,
         monitor: Union[ModeMonitor, ModeSolverMonitor],
-        mode_index: pd.NonNengativeInt = 0,
+        mode_index: pd.NonNegativeInt = 0,
         frequency: Optional[pd.PositiveFloat] = None,
     ) -> ModeABCBoundary:
         """Instantiate from a ``ModeMonitor`` or ``ModeSolverMonitor``.
@@ -206,7 +206,7 @@ def from_monitor(
         ----------
         monitor : Union[:class:`ModeMonitor`, :class:`ModeSolverMonitor`]
             Mode monitor.
-        mode_index : pd.NonNengativeInt = 0
+        mode_index : pd.NonNegativeInt = 0
             Mode index.
         frequency : Optional[pd.PositiveFloat] = None
             Frequency for estimating propagation index of absorbed mode.
@@ -1000,7 +1000,7 @@ def mode_abc(
             Cross-sectional plane in which the absorbed mode will be computed.
         mode_spec: ModeSpec = ModeSpec()
             Parameters that determine the modes computed by the mode solver.
-        mode_index : pd.NonNengativeInt = 0
+        mode_index : pd.NonNegativeInt = 0
             Mode index.
         frequency : Optional[pd.PositiveFloat] = None
             Frequency for estimating propagation index of absorbed mode.
@@ -1050,7 +1050,7 @@ def mode_abc_from_source(cls, source: ModeSource):
     def mode_abc_from_monitor(
         cls,
         monitor: Union[ModeMonitor, ModeSolverMonitor],
-        mode_index: pd.NonNengativeInt = 0,
+        mode_index: pd.NonNegativeInt = 0,
         frequency: Optional[pd.PositiveFloat] = None,
     ):
         """One-way wave equation mode ABC boundary specification on both sides along a dimension constructed from a mode monitor.

tidy3d/components/eme/simulation.py

@@ -212,7 +212,8 @@ class EMESimulation(AbstractYeeGridSimulation):
     internal_absorbers: tuple[()] = pd.Field(
         (),
         title="Internal Absorbers",
-        description="Planes with the first order absorbing boundary conditions placed inside the computational domain.",
+        description="Planes with the first order absorbing boundary conditions placed inside the computational domain. "
+        "Note: absorbers are not supported in EME simulations.",
     )
 
     grid_spec: GridSpec = pd.Field(

tidy3d/components/mode/simulation.py

@@ -171,7 +171,8 @@ class ModeSimulation(AbstractYeeGridSimulation):
     internal_absorbers: tuple[()] = pd.Field(
         (),
         title="Internal Absorbers",
-        description="Planes with the first order absorbing boundary conditions placed inside the computational domain.",
+        description="Planes with the first order absorbing boundary conditions placed inside the computational domain. "
+        "Note: absorbers are not supported in mode simulations.",
     )
 
     grid_spec: GridSpec = pd.Field(

tidy3d/components/simulation.py

@@ -3585,7 +3585,7 @@ def _abc_boundaries_homogeneous(cls, val, values):
 
                     if isinstance(list(mediums)[0], (AnisotropicMedium, FullyAnisotropicMedium)):
                         raise SetupError(
-                            "An anisotropic medium is detected on an 'ABCBoundary. "
+                            "An anisotropic medium is detected on an 'ABCBoundary'. "
                             "Boundary medium must be homogeneous and isotropic."
                         )
 

tidy3d/plugins/smatrix/ports/wave.py

@@ -193,7 +193,7 @@ def to_mode_solver(self, simulation: Simulation, freqs: FreqArray) -> ModeSolver
         return mode_solver
 
     def to_absorber(self, snap_center: Optional[float] = None) -> InternalAbsorber:
-        """Create a mode source from the wave port."""
+        """Create an internal absorber from the wave port."""
         center = list(self.center)
         if snap_center:
             center[self.injection_axis] = snap_center