Skip to content

Commit 3299996

Browse files
committed
fix: wrongly decorated _validate_inplane_pec validator
1 parent 174ff3b commit 3299996

File tree

3 files changed

+2
-2
lines changed

3 files changed

+2
-2
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ with fewer layers than recommended.
3232
- Fixed incorrect gradient computation in PyTorch plugin (`to_torch`) for functions returning multi-element arrays.
3333
- `MonitorData.get_amplitude()` no longers multiplies by a factor of `1j` and now directly returns the complex value of the data.
3434
- `EMESimulationData.port_modes_tuple` is now symmetry-expanded.
35+
- Fixed `Medium2D` validation error message when invalid data is passed to `ss`.
3536

3637
## [2.9.0rc1] - 2025-06-10
3738

tidy3d/components/medium.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7036,8 +7036,8 @@ def _validate_modulation_spec(cls, val):
70367036
)
70377037
return val
70387038

7039-
@skip_if_fields_missing(["ss"])
70407039
@pd.validator("tt", always=True)
7040+
@skip_if_fields_missing(["ss"])
70417041
def _validate_inplane_pec(cls, val, values):
70427042
"""ss/tt components must be both PEC or non-PEC."""
70437043
if isinstance(val, PECMedium) != isinstance(values["ss"], PECMedium):

tidy3d/components/tcad/simulation/heat_charge.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,6 @@ def estimate_charge_mesh_size(cls, values):
889889
)
890890
return values
891891

892-
@skip_if_fields_missing(["analysis_spec", "monitors", "structures", "size"])
893892
@pd.root_validator(skip_on_failure=True)
894893
def check_transient_heat(cls, values):
895894
"""Make sure transient heat simulations can run."""

0 commit comments

Comments
 (0)